Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chaos Engineering to the main Glossary - english version #498

Merged
merged 14 commits into from
Mar 6, 2022
Merged

Add Chaos Engineering to the main Glossary - english version #498

merged 14 commits into from
Mar 6, 2022

Conversation

fsbaraglia
Copy link
Collaborator

split and contains only chaos engineering concept

@netlify
Copy link

netlify bot commented Mar 1, 2022 •
edited
Loading

✔️ Deploy Preview for cncfglossary ready!

🔨 Explore the source changes: af6bed5

🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/6224c90f10e2520007322f1b

😎 Browse the preview: https://deploy-preview-498--cncfglossary.netlify.app/chaos_engineering

@fsbaraglia fsbaraglia changed the title Term/chaos engineering Add Term chaos engineering Mar 1, 2022
@fsbaraglia fsbaraglia mentioned this pull request Mar 1, 2022
Merged
@fsbaraglia fsbaraglia changed the title Add Term chaos engineering Add Chaos Engineering to the main Glossary - english version Mar 1, 2022
@fsbaraglia fsbaraglia mentioned this pull request Mar 1, 2022
Closed
@jihoon-seo jihoon-seo added the lang/en for English label Mar 2, 2022
iamNoah1
iamNoah1 reviewed Mar 2, 2022
View reviewed changes
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fsbaraglia. The content looks good overall, I just have two small suggestions.

content/en/chaos_engineering.md Outdated Show resolved Hide resolved
content/en/chaos_engineering.md Outdated Show resolved Hide resolved
@fsbaraglia
Copy link
Collaborator Author

@iamNoah1 please check again , I added some important parts about Chaos Experiments

@seokho-son
Copy link
Collaborator

FYI :)

Misspelled words:
<htmlcontent> content/en/chaos_engineering.md: html>body>p
--------------------------------------------------------------------------------
technics
--------------------------------------------------------------------------------

!!!Spelling check failed!!!
Error: Files in repository contain spelling errors

@CathPag
Small edit
efc90dc 
Changed "people working in SRE and DevOps" to "SRE and DevOps engineers." Less words, same meaning :)
@fsbaraglia
Copy link
Collaborator Author

new version ready for review

@CathPag
Copy link
Collaborator

CathPag commented Mar 5, 2022

Awesome! I added links to SRE and DevOps. @iamNoah1, let me know what you think. Can't wait to get this one and the other PR merged :)

iamNoah1
iamNoah1 approved these changes Mar 6, 2022
View reviewed changes
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patience and consistency @fsbaraglia. I think now we have pretty good content :)

lgtm

@fsbaraglia
Copy link
Collaborator Author

Thanks for the patience and consistency @fsbaraglia. I think now we have pretty good content :)

lgtm

Super, Danke dir :)

CathPag
CathPag approved these changes Mar 6, 2022
View reviewed changes
Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Great job, @fsbaraglia! This is an awesome addition to the glossary 🎉

@CathPag CathPag merged commit 8741ae6 into cncf:main Mar 6, 2022
@fsbaraglia
Copy link
Collaborator Author

Yay! Great job, @fsbaraglia! This is an awesome addition to the glossary 🎉

Thank you very much @CathPag

@fsbaraglia fsbaraglia deleted the term/chaos_engineering branch March 7, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CathPag CathPag CathPag approved these changes

@iamNoah1 iamNoah1 iamNoah1 approved these changes

@caniszczyk caniszczyk Awaiting requested review from caniszczyk caniszczyk is a code owner

@JasonMorgan JasonMorgan Awaiting requested review from JasonMorgan

@seokho-son seokho-son Awaiting requested review from seokho-son seokho-son is a code owner

@jihoon-seo jihoon-seo Awaiting requested review from jihoon-seo jihoon-seo is a code owner

Assignees
No one assigned
Labels
lang/en for English
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fsbaraglia @seokho-son @CathPag @iamNoah1 @jihoon-seo