Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] L10n of Feedback section #519

Merged
merged 1 commit into from
Mar 15, 2022
Merged

[ko] L10n of Feedback section #519

merged 1 commit into from
Mar 15, 2022

Conversation

jihoon-seo
Copy link
Collaborator

@jihoon-seo jihoon-seo commented Mar 3, 2022 •
edited
Loading

@jihoon-seo jihoon-seo added the lang/ko for Korean label Mar 3, 2022
@netlify
Copy link

netlify bot commented Mar 3, 2022 •
edited
Loading

✔️ Deploy Preview for cncfglossary ready!

🔨 Explore the source changes: fd484a9

🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/622eb44d8c9b5e00085bed45

😎 Browse the preview: https://deploy-preview-519--cncfglossary.netlify.app

@jihoon-seo jihoon-seo mentioned this pull request Mar 3, 2022
Closed
seokho-son
seokho-son approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seokho-son
Copy link
Collaborator

@jihoon-seo
layouts/partials/feedback.html
이 branch rebasing을 통해 추가되었습니다. 해당 파일은 PR에서 제외하면 되겠습니다.

@jihoon-seo jihoon-seo force-pushed the 220303_L10n_feedback_section branch from 9379008 to fd484a9 Compare March 14, 2022 03:19
@jihoon-seo jihoon-seo requested a review from iamNoah1 as a code owner March 14, 2022 03:19
@jihoon-seo
Copy link
Collaborator Author

@seokho-son 해당 사항을 반영하면서, 최신 dev-ko 로 rebase도 수행하였습니다. 😊
@yunkon-kim 님께도 확인을 부탁드립니다 😊

yunkon-kim
yunkon-kim approved these changes Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@yunkon-kim yunkon-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yunkon-kim
Copy link
Collaborator

기존 Commit 이력과 일관성을 위해 Rebase and merge 처리하고자 합니다.

혹시 이슈가 될만한 부분이 있다면 말씀해주십시오 ^^

@jihoon-seo
Copy link
Collaborator Author

제가 Rebase and merge 를 해 본 적이 있는데.. 개인적으로는 적합하지 않은 것 같고
이미 Rebase가 되어 있기도 해서 저는 Squash and merge 를 추천 드립니다.. 😊

@seokho-son 님께서 단독으로 작성하신 commit 이 7개 포함되어 있는 PR을 제가 Rebase and merge 눌렀더니
image

https://github.com/cloud-barista/cb-tumblebug/commits/main?after=4bc769789f8c231e3606a20314fe1e69da7287a1+489&branch=main
image

main 브랜치에 이렇게 들어갔었던 경험이 있습니다.. 😅

@yunkon-kim
Copy link
Collaborator

아 그런 일이 있으셨군요 😄

Squash and merge로 처리하겠습니다.

@yunkon-kim yunkon-kim merged commit b7d4f27 into cncf:dev-ko Mar 15, 2022
@jihoon-seo jihoon-seo deleted the 220303_L10n_feedback_section branch March 17, 2022 04:20
@Shivansh-yadav13 Shivansh-yadav13 mentioned this pull request Mar 30, 2022
Merged
yunkon-kim pushed a commit to yunkon-kim/glossary that referenced this pull request Apr 21, 2022
@jihoon-seo @yunkon-kim
[ko] L10n of Feedback section (cncf#519)
4dc7d5a
yunkon-kim pushed a commit to yunkon-kim/glossary that referenced this pull request Apr 21, 2022
@jihoon-seo @yunkon-kim
[ko] L10n of Feedback section (cncf#519)
2811741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunkon-kim yunkon-kim yunkon-kim approved these changes

@seokho-son seokho-son seokho-son approved these changes

@caniszczyk caniszczyk Awaiting requested review from caniszczyk

@CathPag CathPag Awaiting requested review from CathPag

@JasonMorgan JasonMorgan Awaiting requested review from JasonMorgan

@iamNoah1 iamNoah1 Awaiting requested review from iamNoah1

Assignees
No one assigned
Labels
lang/ko for Korean
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jihoon-seo @seokho-son @yunkon-kim