-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding issue triage to how-to #541
Conversation
✔️ Deploy Preview for cncfglossary ready! 🔨 Explore the source changes: 0e3abb5 🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/6228664545d0e400078a17d7 😎 Browse the preview: https://deploy-preview-541--cncfglossary.netlify.app/contribute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CathPag Thank you for your devotion!
I left some comment.
PTAL! 😊
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
Thanks for your great suggestions @jihoon-seo :) |
Never mind. I saw your comment in the other issue that it was the file name :) If this looks good to go, can you approve please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CathPag the changes sound good to me in general :)
I have an opinion regarding issue template (the template we are using in the guide)
I think we'd better to use the other issue template for proposing a new term.
The current examples (screenshots) are using English Language Glossary Request
template which dose not includes informative contents. (https://github.com/cncf/glossary/issues/new?assignees=&labels=english&template=en.yml&title=%5BEnglish%5D%3A+GlossaryWordHere)
The latest template includes some guidelines to make applicants provides some contexts for a suggested term. Request to add a new term (Default:English)
Also, the template assigns predefined labels automatically. (currently, lang/en
and new term
)
Maybe we can update the template with more appropriate labels (such as awaiting-triage
)
My suggestion regarding issue templates as follows.
- removing
English Language Glossary Request
template - guiding contributors use
Request to add a new term (Default:English)
template- updating default labels for
Request to add a new term (Default:English)
- updating default labels for
If we agree with the suggestion, I will open a PR to update issue templates.
agreed :) |
Co-authored-by: Seokho Son <shsongist@gmail.com>
Co-authored-by: Seokho Son <shsongist@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @CathPag :) lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
No description provided.