Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added quality section #542

Merged
merged 4 commits into from
Mar 7, 2022
Merged

Added quality section #542

merged 4 commits into from
Mar 7, 2022

Conversation

CathPag
Copy link
Collaborator

@CathPag CathPag commented Mar 5, 2022

No description provided.

@netlify
Copy link

netlify bot commented Mar 5, 2022

✔️ Deploy Preview for cncfglossary ready!

🔨 Explore the source changes: d792d86

🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/6225c23ab576c90008cf0553

😎 Browse the preview: https://deploy-preview-542--cncfglossary.netlify.app

@CathPag CathPag added the documentation Improvements or additions to documentation label Mar 5, 2022
@jihoon-seo
Copy link
Collaborator

Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @CathPag, just a small typo.

content/en/style-guide/_index.md Outdated Show resolved Hide resolved
CathPag and others added 2 commits March 6, 2022 09:22
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this change simplify the paragraph?

content/en/style-guide/_index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

content/en/style-guide/_index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

change request from seokho

Co-authored-by: Seokho Son <shsongist@gmail.com>
@iamNoah1 iamNoah1 merged commit b52feba into main Mar 7, 2022
@jihoon-seo jihoon-seo deleted the style-guide-update branch March 7, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants