Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add term: Debugging #552

Merged
merged 12 commits into from
Mar 28, 2022
Merged

Add term: Debugging #552

merged 12 commits into from
Mar 28, 2022

Conversation

fsbaraglia
Copy link
Collaborator

No description provided.

@netlify
Copy link

netlify bot commented Mar 8, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit fcbb4f4
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6240683f12e247000999775a
😎 Deploy Preview https://deploy-preview-552--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fsbaraglia fsbaraglia mentioned this pull request Mar 8, 2022
@jihoon-seo jihoon-seo linked an issue Mar 8, 2022 that may be closed by this pull request
@jihoon-seo jihoon-seo added the lang/en for English label Mar 8, 2022
Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fsbaraglia! Looks good to me. Submitted a few editorial changes and have one question for the 2nd section.

content/en/debugging.md Outdated Show resolved Hide resolved
content/en/debugging.md Outdated Show resolved Hide resolved
content/en/debugging.md Outdated Show resolved Hide resolved
fsbaraglia and others added 3 commits March 9, 2022 16:45
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one more comment. Just noticed when reading the entire entry.

content/en/debugging.md Outdated Show resolved Hide resolved
@jihoon-seo jihoon-seo changed the title debugging term english version Add term: Debugging Mar 9, 2022
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While reading the term definition I had the impression that we are mixing up Debugging itself as a process and IDE supported Debugging. Especially the how it helps section focuses on IDE based or to be more general tool based debugging. The other sections read more like the general debugging concept or process. My suggestion is to step back and think about the scope of this term. Is it really about debugging as a process/concept? Or is it about Tool based Debugging?

content/en/debugging.md Outdated Show resolved Hide resolved
content/en/debugging.md Outdated Show resolved Hide resolved
@fsbaraglia
Copy link
Collaborator Author

@iamNoah1 ok, I will have a look on how to simplify. On the other hand, we should not over complicate.

What is debugging at the end?
A category of tools and multiple techniques to find bugs.
Nothing more and nothing less.
Or am I wrong @CathPag ?

@iamNoah1
Copy link
Collaborator

@fsbaraglia sure I am not aiming for complicating things as well :) But for correctness. Consider the following two sentences.

"A category of tools and multiple techniques to find bugs."

"Multiple techniques to find bugs, which can be tool based/assisted"

My opinion is that Debugging per se is not tools, and can be done without additional tooling at all.

But lets see what other folks think. @JasonMorgan @seokho-son @jihoon-seo @CathPag

@CathPag
Copy link
Collaborator

CathPag commented Mar 14, 2022

While reading the term definition I had the impression that we are mixing up Debugging itself as a process and IDE supported Debugging. Especially the how it helps section focuses on IDE based or to be more general tool based debugging. The other sections read more like the general debugging concept or process. My suggestion is to step back and think about the scope of this term. Is it really about debugging as a process/concept? Or is it about Tool based Debugging?

I think it should be about the concept itself

@CathPag
Copy link
Collaborator

CathPag commented Mar 14, 2022

@fsbaraglia sure I am not aiming for complicating things as well :) But for correctness. Consider the following two sentences.

"A category of tools and multiple techniques to find bugs."

"Multiple techniques to find bugs, which can be tool based/assisted"

My opinion is that Debugging per se is not tools, and can be done without additional tooling at all.

But lets see what other folks think. @JasonMorgan @seokho-son @jihoon-seo @CathPag

I'll let the technical approvers chime in. My knowledge ton that subject is very limited.

@fsbaraglia
Copy link
Collaborator Author

fsbaraglia commented Mar 14, 2022

Ok, I got your point @iamNoah1
Less tool , more on concept right?

if you can please help us and make some suggestions on what to change , really appreciated

Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsbaraglia thanks for the patience. I had to think this one through and made some suggestions. I am keen to hear your opinion :=

content/en/debugging.md Outdated Show resolved Hide resolved
content/en/debugging.md Outdated Show resolved Hide resolved
content/en/debugging.md Outdated Show resolved Hide resolved
fsbaraglia and others added 3 commits March 23, 2022 20:48
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
@fsbaraglia
Copy link
Collaborator Author

I like it , I am fine with the new version @iamNoah1 , thank you for your support

Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsbaraglia thanks for your patience and contribution :)

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fsbaraglia !
LGTM.

I think this PR is ready to be merged.
To make this document live, we need to change status: Feedback Appreciated to status: Completed.
I guess @CathPag can make a final decision ;)

Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to remove two words from one sentence. Please see my comment.

content/en/debugging.md Outdated Show resolved Hide resolved
@fsbaraglia
Copy link
Collaborator Author

@fsbaraglia thanks for the patience. I had to think this one through and made some suggestions. I am keen to hear your opinion :=

alles klar, danke dir 💯

@iamNoah1 iamNoah1 merged commit 7cf8130 into cncf:main Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/en for English
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[English]: Debugging
5 participants