-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add term: Debugging #552
Add term: Debugging #552
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @fsbaraglia! Looks good to me. Submitted a few editorial changes and have one question for the 2nd section.
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, one more comment. Just noticed when reading the entire entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While reading the term definition I had the impression that we are mixing up Debugging itself as a process and IDE supported Debugging. Especially the how it helps section focuses on IDE based or to be more general tool based debugging. The other sections read more like the general debugging concept or process. My suggestion is to step back and think about the scope of this term. Is it really about debugging as a process/concept? Or is it about Tool based Debugging?
@fsbaraglia sure I am not aiming for complicating things as well :) But for correctness. Consider the following two sentences. "A category of tools and multiple techniques to find bugs." "Multiple techniques to find bugs, which can be tool based/assisted" My opinion is that Debugging per se is not tools, and can be done without additional tooling at all. But lets see what other folks think. @JasonMorgan @seokho-son @jihoon-seo @CathPag |
I think it should be about the concept itself |
I'll let the technical approvers chime in. My knowledge ton that subject is very limited. |
Ok, I got your point @iamNoah1 if you can please help us and make some suggestions on what to change , really appreciated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fsbaraglia thanks for the patience. I had to think this one through and made some suggestions. I am keen to hear your opinion :=
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
I like it , I am fine with the new version @iamNoah1 , thank you for your support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fsbaraglia thanks for your patience and contribution :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fsbaraglia !
LGTM.
I think this PR is ready to be merged.
To make this document live, we need to change status: Feedback Appreciated
to status: Completed
.
I guess @CathPag can make a final decision ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to remove two words from one sentence. Please see my comment.
alles klar, danke dir 💯 |
No description provided.