Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue template for new term proposal #559

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Conversation

seokho-son
Copy link
Collaborator

@seokho-son seokho-son commented Mar 9, 2022

This PR enhances the existing issue template for a new term proposal.

with following enhancements

  • auto-labeling : lang/en, new term, triage/awaiting
  • explain triage procedure (assessment for new term proposal)
  • checklist

link to test the issue template

https://github.com/seokho-son/glossary/issues/new?assignees=&labels=lang%2Fen%2Cnew+term%2Ctriage%2Fawaiting&template=new-term.yml&title=%5BNew+term%5D+%60GlossaryTermHere%60

an opened issue example

https://github.com/seokho-son/glossary/issues/17

image

@seokho-son seokho-son added documentation Improvements or additions to documentation maintainers Use this label if PR requires maintainers to take action labels Mar 9, 2022
@netlify
Copy link

netlify bot commented Mar 9, 2022

✔️ Deploy Preview for cncfglossary ready!

🔨 Explore the source changes: c4544a6

🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/6228b495f3fa3b000945565d

😎 Browse the preview: https://deploy-preview-559--cncfglossary.netlify.app

@iamNoah1
Copy link
Collaborator

iamNoah1 commented Mar 9, 2022

lgtm in general. Just thinking about if we add a checkbox section to also check if the term has not been rejected in the past ?!

@CathPag
Copy link
Collaborator

CathPag commented Mar 9, 2022

lgtm in general. Just thinking about if we add a checkbox section to also check if the term has not been rejected in the past ?!

Do we really think that people will be checking out rejected terms? I think they'll have a quick look at the open issues and submit if there isn't a term for it already. But maybe it's just me, I don't think I'd check :)

@seokho-son
Copy link
Collaborator Author

@iamNoah1 @CathPag

The first checkbox includes a link to issue list with 'new term' label and the list includes both open and closed issues. It will simply checking. List will show overall status of acceptance.

But not using 'triage/not accepted' and implying close issue action as not accepted term. is also good way.

  1. Checklist
    There is no existing issue yet. (shift+click to check existing issues)

Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, LGTM :)

Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iamNoah1 iamNoah1 merged commit 20e587d into main Mar 10, 2022
@seokho-son seokho-son deleted the seokho-son-patch-2 branch May 9, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants