Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content/en/idempotence.md #631

Merged
merged 10 commits into from
Mar 22, 2022
Merged

Add content/en/idempotence.md #631

merged 10 commits into from
Mar 22, 2022

Conversation

shambashib20
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Mar 16, 2022 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

🔨 Explore the source changes: a5c7567

🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/6239ac8bd2001e0008c9095e

😎 Browse the preview: https://deploy-preview-631--cncfglossary.netlify.app/idempotence

@CathPag CathPag added the lang/en for English label Mar 16, 2022
CathPag
CathPag reviewed Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @shambashib20! Since this is a property, we need to change the format. See my comments below.

content/en/idempotence.md Outdated Show resolved Hide resolved
content/en/idempotence.md Outdated Show resolved Hide resolved
shambashib20 and others added 4 commits March 17, 2022 18:01
@shambashib20 @CathPag
Update content/en/idempotence.md
425dc72 
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
@shambashib20
Updated content/en/idempotence.md
4914dc2 
Updated with reviews considered. Open for reviews again!
@CathPag
Changed to property
7ccd9c4
@CathPag
Update idempotence.md
1c8001a
CathPag
CathPag reviewed Mar 18, 2022
View reviewed changes
Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional comment. Would also need @iamNoah1 to review. This is not something I was familiar with.

content/en/idempotence.md Outdated Show resolved Hide resolved
JasonMorgan
JasonMorgan previously requested changes Mar 18, 2022
View reviewed changes
content/en/idempotence.md Outdated Show resolved Hide resolved
@jihoon-seo
Copy link
Collaborator

Spellcheck CI fails.

@shambashib20 Adding a word idempotence to wordlist.txt will solve the problem!

@shambashib20 @jihoon-seo
Update content/en/idempotence.md
04a008c 
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
@jihoon-seo jihoon-seo mentioned this pull request Mar 22, 2022
Closed
@shambashib20
Copy link
Contributor Author

Please help me updating the wordlist.txt. Whenever I am going to update it, it shows me a new patch branch and then it raises a new pr.
What to do?

@shambashib20
Copy link
Contributor Author

I guess I worked it out! Can you check my whole pr @JasonMorgan , @jihoon-seo ?

CathPag
CathPag approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iamNoah1
iamNoah1 approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @shambashib20

@iamNoah1 iamNoah1 dismissed JasonMorgan’s stale review March 22, 2022 11:11

seems to be incorporated

@iamNoah1 iamNoah1 merged commit 96dcc01 into cncf:main Mar 22, 2022
@shambashib20
Copy link
Contributor Author

Thanks a lot! It means a lot to me! Can you guys help me finding another issue on which I can work?

@CathPag
Copy link
Collaborator

CathPag commented Mar 23, 2022

Thanks a lot! It means a lot to me! Can you guys help me finding another issue on which I can work?

The best issue is the term you understand well and feel comfortable working on. Which one that is, depends on your knowledge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihoon-seo jihoon-seo jihoon-seo left review comments

@CathPag CathPag CathPag approved these changes

@iamNoah1 iamNoah1 iamNoah1 approved these changes

@JasonMorgan JasonMorgan JasonMorgan left review comments

@caniszczyk caniszczyk Awaiting requested review from caniszczyk caniszczyk is a code owner

@seokho-son seokho-son Awaiting requested review from seokho-son seokho-son is a code owner

Assignees
No one assigned
Labels
lang/en for English
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shambashib20 @jihoon-seo @CathPag @JasonMorgan @iamNoah1