Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ack hindi localization contributors in _index.md #664

Merged
merged 9 commits into from
Mar 29, 2022

Conversation

Garima-Negi
Copy link
Collaborator

@Garima-Negi Garima-Negi commented Mar 28, 2022

This PR is essential before dev-hi can be merged into main

@netlify
Copy link

netlify bot commented Mar 28, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 81b4ff9
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/624220cc9e468500080fe340
😎 Deploy Preview https://deploy-preview-664--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content/hi/_index.md Outdated Show resolved Hide resolved
remove `?originalSubdomain=in` from linkedin

Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
content/hi/_index.md Outdated Show resolved Hide resolved
@Garima-Negi Garima-Negi added the lang/hi for Hindi label Mar 28, 2022
Copy link
Contributor

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can write names in Hindi too??

content/hi/_index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jayesh-srivastava jayesh-srivastava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Garima-Negi Garima-Negi merged commit f5c3aa0 into cncf:dev-hi Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/hi for Hindi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants