Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi] localize service_mesh.md #674

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Conversation

testsabirweb
Copy link
Contributor

This PR is Hindi localization of content/hi/service_mesh.md
ref: #270 (comment)

Please review the PR

@netlify
Copy link

netlify bot commented Apr 1, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 8f97d21
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/63107169e2b1390008f31916
😎 Deploy Preview https://deploy-preview-674--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@testsabirweb
Copy link
Contributor Author

@anubha-v-ardhan anubha-v-ardhan added the lang/hi for Hindi label Apr 2, 2022
content/hi/service_mesh.md Outdated Show resolved Hide resolved
content/hi/service_mesh.md Outdated Show resolved Hide resolved
content/hi/service_mesh.md Outdated Show resolved Hide resolved
@Garima-Negi
Copy link
Collaborator

LGTM

Copy link
Collaborator

@jayesh-srivastava jayesh-srivastava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@testsabirweb Can you change the file name to service-mesh.md. We prefer keeping the names same as English verison

@Garima-Negi
Copy link
Collaborator

@testsabirweb Can you change the file name to service-mesh.md. We prefer keeping the names same as English verison

Hi @anubha-v-ardhan , can you approve this PR? It had a few changes requested by you hence merging is blocked

@testsabirweb
Copy link
Contributor Author

Hii @anubha-v-ardhan ,
The changes you requested are done, please approve...

@sayantani11 sayantani11 dismissed anubha-v-ardhan’s stale review February 7, 2023 21:07

The changes are addressed as I can see

@sayantani11 sayantani11 merged commit 6083993 into cncf:dev-hi Feb 7, 2023
@sayantani11
Copy link
Contributor

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/hi for Hindi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants