Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESP] add content/es/application_programming_interface.md done #704

Merged
merged 3 commits into from
Aug 2, 2022
Merged

[ESP] add content/es/application_programming_interface.md done #704

merged 3 commits into from
Aug 2, 2022

Conversation

gamba47
Copy link
Contributor

@gamba47 gamba47 commented Apr 6, 2022

Based on #564

Work done.

@netlify
Copy link

netlify bot commented Apr 6, 2022 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit c625cc8
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/62e42408a79f5a0008e15b10
😎 Deploy Preview https://deploy-preview-704--cncfglossary.netlify.app/es/application-programming-interface
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@electrocucaracha electrocucaracha added the lang/es for Spanish label Apr 6, 2022
@jihoon-seo jihoon-seo linked an issue Apr 6, 2022 that may be closed by this pull request
[Spanish] localize 'Application Programming Interface' #564
Closed
@jihoon-seo
Copy link
Collaborator

Preview should be available at https://deploy-preview-704--cncfglossary.netlify.app/es/application_programming_interface/ .

And please refer to #705 (comment) . 😊

raelga
raelga requested changes Apr 7, 2022
View reviewed changes
Copy link
Collaborator

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faltan algunos signos de acentuación y hay algún error tipográfico.

content/es/application_programming_interface.md Outdated
category: technology
---

## ¿Que es?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## ¿Que es?
## ¿Qué es?

content/es/application_programming_interface.md Outdated Show resolved Hide resolved
content/es/application_programming_interface.md Outdated Show resolved Hide resolved
content/es/application_programming_interface.md Outdated Show resolved Hide resolved
@jihoon-seo jihoon-seo added the hold Wait, please do not proceed this yet label Apr 8, 2022
@jihoon-seo jihoon-seo changed the base branch from main to dev-es April 9, 2022 22:56
@jihoon-seo jihoon-seo requested a review from krol3 as a code owner April 9, 2022 22:56
@jihoon-seo jihoon-seo removed the hold Wait, please do not proceed this yet label Apr 9, 2022
@gamba47 gamba47 requested a review from raelga April 18, 2022 18:56
krol3
krol3 reviewed Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@krol3 krol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algunas pequenas sugerencias @gamba47, gracias por tu contribución

content/es/application_programming_interface.md Outdated Show resolved Hide resolved
content/es/application_programming_interface.md Outdated Show resolved Hide resolved
raelga
raelga reviewed Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faltarían microservicios en el diccionario, una vez aceptada la sugerencia de @krol3 que corrige algunos errores tipográficos.

content/es/application_programming_interface.md Outdated Show resolved Hide resolved
gamba47
gamba47 commented Apr 26, 2022
View reviewed changes
Copy link
Contributor Author

@gamba47 gamba47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigo con problemas no me deja aprovar estos cambios :(

@gamba47
Copy link
Contributor Author

gamba47 commented Apr 26, 2022

Me queda hacer los cambios en el diccionario, @electrocucaracha cuando puedas me ayudas? porque tengo el problema que no tengo el diccionario y tampoco el branch dev-es

@raelga
Copy link
Collaborator

raelga commented Jun 10, 2022

Con los últimos cambios, ya estaría pasando todos los checks. Puedes revisar que esté todo correcto?

cc @gamba47 @electrocucaracha

@raelga raelga requested a review from krol3 June 10, 2022 07:58
electrocucaracha
electrocucaracha approved these changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@electrocucaracha electrocucaracha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gamba47 Parece ser que lo único que necesitas es firmar los commits para que pase el CI, en cuanto a lo demás no hay problema en ser mergeado

@gamba47
Copy link
Contributor Author

gamba47 commented Jun 13, 2022

Hola @electrocucaracha ! leo bien y lo hago, parece que hay que hacer un rebase, vamos a aprender algo nuevo! gracias, mas tarde te cuento!

gamba47 and others added 3 commits July 29, 2022 15:16
@gamba47
application_programming_interface.md done
2e1ceb6 
Signed-off-by: Rael Garcia <rael@redhat.com>
Signed-off-by: Emiliano <emilianovazquez@gmail.com>
@raelga @gamba47
clean: apply format conventions
9fa755e 
Signed-off-by: Rael Garcia <rael@redhat.com>
Signed-off-by: Emiliano <emilianovazquez@gmail.com>
@gamba47 @electrocucaracha
Apply suggestions from code review
c625cc8 
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Signed-off-by: Emiliano <emilianovazquez@gmail.com>
@gamba47
Copy link
Contributor Author

gamba47 commented Jul 29, 2022

@electrocucaracha estoy con la ayuda de @ramrodo y me esta ayudando a firmar todo, este parece que quedo ok !

@electrocucaracha electrocucaracha merged commit 69817e9 into cncf:dev-es Aug 2, 2022
electrocucaracha added a commit to electrocucaracha/glossary that referenced this pull request Aug 30, 2022
@gamba47 @electrocucaracha @raelga
[ESP] add content/es/application_programming_interface.md done (cncf#704
686f312 
)

* application_programming_interface.md done
* clean: apply format conventions
* Apply suggestions from code review

Signed-off-by: Emiliano <emilianovazquez@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@redhat.com>
electrocucaracha added a commit to electrocucaracha/glossary that referenced this pull request Aug 30, 2022
@gamba47 @electrocucaracha @raelga
[ESP] add content/es/application_programming_interface.md done (cncf#704
d805079 
)

* application_programming_interface.md done
* clean: apply format conventions
* Apply suggestions from code review

Signed-off-by: Emiliano <emilianovazquez@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@redhat.com>
electrocucaracha added a commit to electrocucaracha/glossary that referenced this pull request Sep 1, 2022
@gamba47 @electrocucaracha @raelga
[ESP] add content/es/application_programming_interface.md done (cncf#704
8d1b14d 
)

* application_programming_interface.md done
* clean: apply format conventions
* Apply suggestions from code review

Signed-off-by: Emiliano <emilianovazquez@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@redhat.com>
electrocucaracha added a commit to electrocucaracha/glossary that referenced this pull request Sep 1, 2022
@gamba47 @electrocucaracha @raelga
[ESP] add content/es/application_programming_interface.md done (cncf#704
2003ad8 
)

* application_programming_interface.md done
* clean: apply format conventions
* Apply suggestions from code review

Signed-off-by: Emiliano <emilianovazquez@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@redhat.com>
seokho-son pushed a commit to seokho-son/glossary that referenced this pull request Sep 13, 2022
@gamba47 @electrocucaracha
@raelga @seokho-son
[ESP] add content/es/application_programming_interface.md done (cncf#704
e3ca359 
)

* application_programming_interface.md done
* clean: apply format conventions
* Apply suggestions from code review

Signed-off-by: Emiliano <emilianovazquez@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@redhat.com>
electrocucaracha added a commit to electrocucaracha/glossary that referenced this pull request Sep 14, 2022
@gamba47 @electrocucaracha @raelga
[ESP] add content/es/application_programming_interface.md done (cncf#704
b0d3f4c 
)

* application_programming_interface.md done
* clean: apply format conventions
* Apply suggestions from code review

Signed-off-by: Emiliano <emilianovazquez@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@redhat.com>
ramrodo pushed a commit to ramrodo/glossary that referenced this pull request Oct 3, 2022
@gamba47 @electrocucaracha
@raelga @ramrodo
[ESP] add content/es/application_programming_interface.md done (cncf#704
da72f8b 
)

* application_programming_interface.md done
* clean: apply format conventions
* Apply suggestions from code review

Signed-off-by: Emiliano <emilianovazquez@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@redhat.com>
ramrodo pushed a commit to ramrodo/glossary that referenced this pull request Dec 13, 2022
@gamba47 @electrocucaracha
@raelga @ramrodo
[ESP] add content/es/application_programming_interface.md done (cncf#704
e533dcc 
)

* application_programming_interface.md done
* clean: apply format conventions
* Apply suggestions from code review

Signed-off-by: Emiliano <emilianovazquez@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@redhat.com>
seokho-son pushed a commit to seokho-son/glossary that referenced this pull request Mar 20, 2023
@gamba47 @electrocucaracha
@raelga @seokho-son
[ESP] add content/es/application_programming_interface.md done (cncf#704
093e216 
)

* application_programming_interface.md done
* clean: apply format conventions
* Apply suggestions from code review

Signed-off-by: Emiliano <emilianovazquez@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrocucaracha electrocucaracha electrocucaracha approved these changes

@raelga raelga raelga approved these changes

@krol3 krol3 Awaiting requested review from krol3 krol3 is a code owner

Assignees
No one assigned
Labels
lang/es for Spanish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Spanish] localize 'Application Programming Interface'
5 participants
@gamba47 @jihoon-seo @raelga @electrocucaracha @krol3