Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[de] Abstraction #730

Merged
merged 6 commits into from
May 2, 2022
Merged

[de] Abstraction #730

merged 6 commits into from
May 2, 2022

Conversation

gdenn
Copy link
Contributor

@gdenn gdenn commented Apr 12, 2022

issue: #505

@netlify
Copy link

netlify bot commented Apr 12, 2022 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit ca54a93
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/625bf92348df4c0009f26429
😎 Deploy Preview https://deploy-preview-730--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@gdenn gdenn mentioned this pull request Apr 12, 2022
Closed
@gdenn
Copy link
Contributor Author

gdenn commented Apr 12, 2022

Preview -> https://deploy-preview-730--cncfglossary.netlify.app/de/abstraction/

@jihoon-seo jihoon-seo added the lang/de for German label Apr 13, 2022
DaveVentura
DaveVentura requested changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@DaveVentura DaveVentura left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liest sich gut.
Hab noch ein paar Kommentare hinterlassen aber ansonsten kann das so raus bzw. rein^^ :)

@gdenn
Copy link
Contributor Author

gdenn commented Apr 13, 2022 •
edited
Loading

@DaveVentura danke fürs reviewen :)

@jihoon-seo jihoon-seo linked an issue Apr 13, 2022 that may be closed by this pull request
[German] Localize 'Abstraction' #505
Closed
iamNoah1
iamNoah1 requested changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gdenn danke für den Beitrag. Habe nur ein paar kleinere Anmerkungen.

content/de/abstraction.md Outdated Show resolved Hide resolved
content/de/abstraction.md Outdated Show resolved Hide resolved
iamNoah1
iamNoah1 approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaveVentura DaveVentura merged commit 6570292 into cncf:dev-de May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveVentura DaveVentura DaveVentura approved these changes

@iamNoah1 iamNoah1 iamNoah1 approved these changes

@CathPag CathPag Awaiting requested review from CathPag CathPag is a code owner

@Petria3s Petria3s Awaiting requested review from Petria3s

Assignees
No one assigned
Labels
lang/de for German
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[German] Localize 'Abstraction'
4 participants
@gdenn @iamNoah1 @DaveVentura @jihoon-seo