[ko] Translate 'How To Contribute' into Korean #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihoon-seo
requested review from
seokho-son,
Eviekim and
yunkon-kim
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jihoon-seo
commented
Apr 15, 2022
|
|
||
| 여러 템플릿이 보일 것이다. 새로운 영문 용어를 제안하려면, "Request to add a new term (English)" 를 선택한다. | ||
|
|
||
|  |
There was a problem hiding this comment.
Preview에서 이 이미지만 404 Not found로 보입니다.
- (404 Not found) https://deploy-preview-747--cncfglossary.netlify.app/images/how-to/english-issue-template.jpg
- (정상적으로 보임) https://glossary.cncf.io/images/how-to/english-issue-template.jpg
Netlify preview instance에 이 jpg 파일이 제대로 올라가지 않아서 그런 것으로 추정됩니다.
dev-ko 내지는 main에 merge되면 정상적으로 보일 것 같습니다.
jihoon-seo
commented
Apr 15, 2022
seokho-son
reviewed
Apr 19, 2022
|
@seokho-son 리뷰 감사합니다. 😊 변경 사항을 쉽게 확인하실 수 있도록 squash는 아직 하지 않았으며, 필요한 경우 진행하겠습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant with #379 (comment)
참고: 영어 원문 파일은
dev-ko의 것이 아니라main의 것을 이용했습니다.Preview: https://deploy-preview-747--cncfglossary.netlify.app/ko/contribute/