How it works URL clarification #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CathPag
requested review from
caniszczyk,
JasonMorgan,
seokho-son,
iamNoah1 and
jihoon-seo
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
seokho-son
reviewed
May 8, 2022
There was a problem hiding this comment.
I added no parentheses :)
to prevent filenames like TLS(Transport Layer Security).md
Co-authored-by: Seokho Son <shsongist@gmail.com>
|
@CathPag can you please resolve the merge conflicts :) |
|
thanks @jihoon-seo |
JunchengL
pushed a commit
to JunchengL/glossary
that referenced
this pull request
May 21, 2022
* How it works URL clarification * Update _index.md * Update content/en/contribute/_index.md Co-authored-by: Seokho Son <shsongist@gmail.com> Co-authored-by: Seokho Son <shsongist@gmail.com> Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
Jacob953
pushed a commit
to Jacob953/glossary
that referenced
this pull request
Jun 17, 2022
* How it works URL clarification * Update _index.md * Update content/en/contribute/_index.md Co-authored-by: Seokho Son <shsongist@gmail.com> Co-authored-by: Seokho Son <shsongist@gmail.com> Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
Jacob953
pushed a commit
to Jacob953/glossary
that referenced
this pull request
Jun 22, 2022
* How it works URL clarification * Update _index.md * Update content/en/contribute/_index.md Co-authored-by: Seokho Son <shsongist@gmail.com> Co-authored-by: Seokho Son <shsongist@gmail.com> Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
Jacob953
pushed a commit
to Jacob953/glossary
that referenced
this pull request
Jun 22, 2022
* How it works URL clarification * Update _index.md * Update content/en/contribute/_index.md Co-authored-by: Seokho Son <shsongist@gmail.com> Co-authored-by: Seokho Son <shsongist@gmail.com> Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com> Signed-off-by: Jacob953 <jacob953@csu.edu.cn>
Jacob953
pushed a commit
to Jacob953/glossary
that referenced
this pull request
Jun 22, 2022
* How it works URL clarification * Update _index.md * Update content/en/contribute/_index.md Co-authored-by: Seokho Son <shsongist@gmail.com> Co-authored-by: Seokho Son <shsongist@gmail.com> Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com> Signed-off-by: Jacob953 <jacob953@csu.edu.cn>
JunchengL
pushed a commit
to JunchengL/glossary
that referenced
this pull request
Sep 20, 2022
* How it works URL clarification * Update _index.md * Update content/en/contribute/_index.md Co-authored-by: Seokho Son <shsongist@gmail.com> Co-authored-by: Seokho Son <shsongist@gmail.com> Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @jihoon-seo's comment in this issue.
Jihoon, is - ok or should I change to _?