Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge dev-es into main (for the first Spanish localization live version) #806

Merged
merged 74 commits into from
May 4, 2022
Merged

Merge dev-es into main (for the first Spanish localization live version) #806

merged 74 commits into from
May 4, 2022

Conversation

electrocucaracha
Copy link
Collaborator

@electrocucaracha electrocucaracha commented Apr 29, 2022 •
edited by seokho-son
Loading

Merge Spanish development branch into main.

Requirements to go live have been completed.

https://github.com/cncf/glossary/projects/5

Check list to make localization live.

  • validate all files which are not in the localization directory (content/es/*)
  • check i18n/es.toml exist
  • check l10n configuration in config.toml
  • acknowledge to initial localization contributors list
  • check Preview works

electrocucaracha and others added 30 commits February 17, 2022 09:23
@electrocucaracha
Add initial localized content for spanish (#388)
70b4fc3
@seokho-son
Update CODEOWNDERS for dev-es
0adf19a
@electrocucaracha
Enable PySpelling checker tool to Spanish language
affb62f
@krol3
feat: add content es/observability
ceb5229
@raelga
Merge pull request #467 from krol3/es-obser
1cec953 
feat: add content es/observability
@seokho-son
Merge pull request #405 from electrocucaracha/add_es-spellchecker
b7eb45e 
Enable Spanish spelling checker tool
@krol3
feat: add content /es/devops
1e33c5a
@krol3
chore: rev01
04c6a2a
@krol3
chore: cola
c91a6f1
@electrocucaracha
Update wordlist
edf5416
@krol3
Merge pull request #1 from electrocucaracha/krol3-devops
bbca7a5 
Fix CI spelling issues
@electrocucaracha
Translate Cloud Computing to spanish
8d19e83 
Closes #571
@raelga
fix: use estrechament instead of alto
a11be5d 
Discussed during the weekly meeting.
@raelga
Merge pull request #411 from krol3/dev-es
f4427a8 
feat: add content /es/devops
@electrocucaracha
Add initial localized content for spanish (#388)
30bcc46
@krol3 @electrocucaracha
feat: add content es/observability
36a745e
@electrocucaracha
Enable PySpelling checker tool to Spanish language
583777e
@krol3 @electrocucaracha
feat: add content /es/devops
ad45c60
@krol3 @electrocucaracha
chore: rev01
3efc9c0
@krol3 @electrocucaracha
chore: cola
ae76a7d
@electrocucaracha
Update wordlist
8965be5
@raelga @electrocucaracha
fix: use estrechament instead of alto
c1a387e 
Discussed during the weekly meeting.
@electrocucaracha
Merge branch 'dev-es' into dev-es
4aa3fb7
@seokho-son
Merge pull request #629 from electrocucaracha/dev-es
99dda80 
 chore: update dev-es branch with main branch
@krol3
[es] Translate 'Abstraction' into Spanish (#633)
8933ae6 
* feat: spanish abstraction
* revision: es abtraction

Co-authored-by: carolina valencia <krol3@users.noreply.github.com>
@raelga
Merge branch 'dev-es' into add_cloud-computing
5f060f5
@raelga
Merge pull request #593 from electrocucaracha/add_cloud-computing
93f6937 
feat: add content es/cloud_computing
@electrocucaracha
Add initial localized content for spanish (#388)
c95c073
@krol3 @electrocucaracha
feat: add content es/observability
facab56
@electrocucaracha
Enable PySpelling checker tool to Spanish language
6fc23d9
@netlify
Copy link

netlify bot commented Apr 29, 2022 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 7915022
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6271c1b8b667810009508611
😎 Deploy Preview https://deploy-preview-806--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@electrocucaracha electrocucaracha added the lang/es for Spanish label Apr 29, 2022
@seokho-son
Copy link
Collaborator

Hello, @electrocucaracha :)
Please add acknowledgement to Spanish localization contributors to _index.md. (similar style with ack to Glossary contribution)

You can open another PR to add it.

@electrocucaracha
Copy link
Collaborator Author

Hello, @electrocucaracha :) Please add acknowledgement to Spanish localization contributors to _index.md. (similar style with ack to Glossary contribution)

You can open another PR to add it.

Ok, I wasn't sure about those changes. I opened the #807 PR

krol3
krol3 approved these changes May 1, 2022
View reviewed changes
Copy link
Collaborator

@krol3 krol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jihoon-seo
Copy link
Collaborator

@electrocucaracha In preview, the Spanish version of "Contributor Ladder" page is missing.
Could you (or anyone in Spanish L10n team) add this? 😊

jihoon-seo
jihoon-seo reviewed May 1, 2022
View reviewed changes
Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Spanish L10n team,
muchas gracias for your work!

And I left some comments. PTAL! 😊

content/es/_index.md Outdated Show resolved Hide resolved
content/es/_index.md Outdated Show resolved Hide resolved
content/es/abstraction.md Outdated Show resolved Hide resolved
content/es/api_gateway.md Outdated Show resolved Hide resolved
content/es/contribute/_index.md Outdated Show resolved Hide resolved
content/es/style-guide/_index.md Outdated Show resolved Hide resolved
content/es/style-guide/_index.md Outdated Show resolved Hide resolved
content/es/style-guide/_index.md Outdated Show resolved Hide resolved
content/es/style-guide/_index.md Outdated Show resolved Hide resolved
content/es/contribute/_index.md Outdated Show resolved Hide resolved
@electrocucaracha
chore: Update index spanish files (#807)
fab4ba2 
* Add acknowledgements for spanish contributors

* Update contribution guide spanish version

* Link Spanish versions

* Remove glossary hardcoded site domain

* Fix linting issues

* Fix API link

* Remove topnav icons

* Change to https the guidetogrammar link
@seokho-son
Copy link
Collaborator

This PR looks good to me except the issue @jihoon-seo commented.

@electrocucaracha In preview, the Spanish version of "Contributor Ladder" page is missing. Could you (or anyone in Spanish L10n team) add this? 😊

But, I think it is ok without Spanish version of "Contributor Ladder" page for the first live version.
The page can be included in a next round.

I think decision is up to Spanish team :)

@electrocucaracha do you want include Spanish version of "Contributor Ladder" this time ?

@electrocucaracha
Copy link
Collaborator Author

This PR looks good to me except the issue @jihoon-seo commented.

@electrocucaracha In preview, the Spanish version of "Contributor Ladder" page is missing. Could you (or anyone in Spanish L10n team) add this? 😊

But, I think it is ok without Spanish version of "Contributor Ladder" page for the first live version. The page can be included in a next round.

I think decision is up to Spanish team :)

@electrocucaracha do you want include Spanish version of "Contributor Ladder" this time ?

@seokho-son I'm working on that document, but it may require some time to give eyes from reviewers. If this PR doesn't brake anything of main I'd suggest proceeding to merge it.

@electrocucaracha @jihoon-seo
feat: add content es/contributor-ladder/_index.md (#830)
7915022 
* Translate Contributor Ladder to spanish

* Fix CI path for Spanish spellchecker

* [es] Update links to point localized pages

Co-authored-by: Jihoon Seo <jihoon.seo@etri.re.kr>
jihoon-seo
jihoon-seo approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seokho-son seokho-son added the maintainers Use this label if PR requires maintainers to take action label May 4, 2022
seokho-son
seokho-son approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGGGGGGGTM ! :)

@seokho-son seokho-son merged commit ba4574e into main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihoon-seo jihoon-seo jihoon-seo approved these changes

@krol3 krol3 krol3 approved these changes

@seokho-son seokho-son seokho-son approved these changes

@raelga raelga Awaiting requested review from raelga raelga is a code owner

@caniszczyk caniszczyk Awaiting requested review from caniszczyk caniszczyk is a code owner

@CathPag CathPag Awaiting requested review from CathPag

@JasonMorgan JasonMorgan Awaiting requested review from JasonMorgan

@iamNoah1 iamNoah1 Awaiting requested review from iamNoah1 iamNoah1 is a code owner

Assignees
No one assigned
Labels
lang/es for Spanish maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@electrocucaracha @seokho-son @jihoon-seo @krol3 @raelga @anyulled @gamba47 @ShankyJS @jthan24