Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] CI definition #924

Merged

Conversation

CristianFrancisco85
Copy link
Contributor

Based on #581

@netlify
Copy link

netlify bot commented Jun 2, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 04052c1
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/629f7a37495bc80008656043
😎 Deploy Preview https://deploy-preview-924--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@electrocucaracha electrocucaracha added the lang/es for Spanish label Jun 2, 2022
Copy link
Collaborator

@electrocucaracha electrocucaracha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias @CristianFrancisco85 por traducir el concepto de Integración continua, he dejado un par de observaciones en el documento que me parecen necesarias.

Respecto a los errores reportados por GitHub Actions:

  • DCO esto se soluciona firmando los commit messages git commit -s
  • Spellcheck. Es necesario agregar una serie de palabras al diccionario de español. Me parece que las palabras a agregar después de aplicar mis sugerencias serian: Git, Mercurial y Subversion. Generalmente, las agregamos en orden alfabético para fácilmente identificar duplicidad.

content/es/continuous_integration.md Outdated Show resolved Hide resolved
content/es/continuous_integration.md Outdated Show resolved Hide resolved
content/es/continuous_integration.md Outdated Show resolved Hide resolved
content/es/continuous_integration.md Outdated Show resolved Hide resolved
content/es/continuous_integration.md Outdated Show resolved Hide resolved
content/es/continuous_integration.md Outdated Show resolved Hide resolved
content/es/continuous_integration.md Outdated Show resolved Hide resolved
content/es/continuous_integration.md Outdated Show resolved Hide resolved
content/es/continuous_integration.md Outdated Show resolved Hide resolved
content/es/continuous_integration.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@electrocucaracha electrocucaracha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parece ser que el primer commit no fue firmado, quizá tengas que hacer algo con un rebase interactivo.

@CristianFrancisco85
Copy link
Contributor Author

Hmmm creo que eso no funciono. Voy a ver como resolver lo de firmar el primer commit

@electrocucaracha
Copy link
Collaborator

@CristianFrancisco85 en general los cambios se ven bien, quizá de mi parte solo sería necesario agregar espacios entre el título y los párrafos traducidos, ya que se está realizando un esfuerzo general por estandarizar esa parte

@jihoon-seo
Copy link
Collaborator

@CristianFrancisco85 Thank you for your contribution!
My suggestions are:

  • It would be great to rename content/es/continuous_integration.md to content/es/continuous-integration.md.
    (This renaming could be performed in another PR of course, but if handled in this PR,
    it would reduce the maintenance efforts and keep the commit timeline neat!)
  • Among 5 commits in this PR, could you keep only actually-effective 2 commits (3273348, 549e5eb),
    excluding other 3 commits (93aedcb, 28f5a75, 6a720cd)?
    And when you work on this, it would also be great to squash those 2 commits (3273348, 549e5eb)
    into one single commit. 😊

@electrocucaracha @raelga What about your thoughts, as es approvers? 😊

@electrocucaracha
Copy link
Collaborator

* Among 5 commits in this PR, could you keep only actually-effective 2 commits ([3273348](https://github.com/cncf/glossary/commit/32733488c1b49e1c6113aedb1ccd71dbec4fc2e4), [549e5eb](https://github.com/cncf/glossary/commit/549e5eb5405a57973ce68403f9a19207c5df16cd)),
  excluding other 3 commits ([93aedcb](https://github.com/cncf/glossary/commit/93aedcbf6a774f08bf301eb82eaf633a239037d2), [28f5a75](https://github.com/cncf/glossary/commit/28f5a758c4742ace1a3d508eee2eb32df9644e87), [6a720cd](https://github.com/cncf/glossary/commit/6a720cd78402e90391565db970b53571efe4638f))?
  And when you work on this, it would also be great to squash those 2 commits ([3273348](https://github.com/cncf/glossary/commit/32733488c1b49e1c6113aedb1ccd71dbec4fc2e4), [549e5eb](https://github.com/cncf/glossary/commit/549e5eb5405a57973ce68403f9a19207c5df16cd))
  into one single commit. 😊

I was thinking to use Squash and Merge option on this PR to reduce the number of commits

@raelga
Copy link
Collaborator

raelga commented Jun 3, 2022

@CristianFrancisco85 puedes revisar el comentario #924 (comment) y hacer los cambios en los nombres?

@jihoon-seo
Copy link
Collaborator

@electrocucaracha OK then, please edit the commit message suitably when you perform Squash and Merge. :)

@CristianFrancisco85
Copy link
Contributor Author

@electrocucaracha Creo que lo mas prudente será hacer otro pull request.

@electrocucaracha
Copy link
Collaborator

Si gustas @CristianFrancisco85 , puedo ayudarte con las instrucciones para que no hagas otro PR, es muy sencillo contactame por slack o el martes lo vemos en la junta

CristianFrancisco85 and others added 4 commits June 7, 2022 18:12
Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com>
Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com>
Signed-off-by: Rael Garcia <rael@rael.io>
@raelga raelga force-pushed the feature/es_glossary_CI branch from 76ac76a to 04052c1 Compare June 7, 2022 16:17
@electrocucaracha electrocucaracha merged commit 342f18d into cncf:dev-es Jun 7, 2022
electrocucaracha pushed a commit to electrocucaracha/glossary that referenced this pull request Aug 30, 2022
* CI definition
* Fix typos and word added to dictionary
* Update and rename continuous_integration.md to continuous-integration.md
* Add line break space content/es/continuous-integration.md

Signed-off-by: Rael Garcia <rael@rael.io>
Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
electrocucaracha pushed a commit to electrocucaracha/glossary that referenced this pull request Aug 30, 2022
* CI definition
* Fix typos and word added to dictionary
* Update and rename continuous_integration.md to continuous-integration.md
* Add line break space content/es/continuous-integration.md

Signed-off-by: Rael Garcia <rael@rael.io>
Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
electrocucaracha pushed a commit to electrocucaracha/glossary that referenced this pull request Sep 1, 2022
* CI definition
* Fix typos and word added to dictionary
* Update and rename continuous_integration.md to continuous-integration.md
* Add line break space content/es/continuous-integration.md

Signed-off-by: Rael Garcia <rael@rael.io>
Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
electrocucaracha pushed a commit to electrocucaracha/glossary that referenced this pull request Sep 1, 2022
* CI definition
* Fix typos and word added to dictionary
* Update and rename continuous_integration.md to continuous-integration.md
* Add line break space content/es/continuous-integration.md

Signed-off-by: Rael Garcia <rael@rael.io>
Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
seokho-son pushed a commit to seokho-son/glossary that referenced this pull request Sep 13, 2022
* CI definition
* Fix typos and word added to dictionary
* Update and rename continuous_integration.md to continuous-integration.md
* Add line break space content/es/continuous-integration.md

Signed-off-by: Rael Garcia <rael@rael.io>
Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
electrocucaracha pushed a commit to electrocucaracha/glossary that referenced this pull request Sep 14, 2022
* CI definition
* Fix typos and word added to dictionary
* Update and rename continuous_integration.md to continuous-integration.md
* Add line break space content/es/continuous-integration.md

Signed-off-by: Rael Garcia <rael@rael.io>
Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
ramrodo pushed a commit to ramrodo/glossary that referenced this pull request Oct 3, 2022
* CI definition
* Fix typos and word added to dictionary
* Update and rename continuous_integration.md to continuous-integration.md
* Add line break space content/es/continuous-integration.md

Signed-off-by: Rael Garcia <rael@rael.io>
Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
ramrodo pushed a commit to ramrodo/glossary that referenced this pull request Dec 13, 2022
* CI definition
* Fix typos and word added to dictionary
* Update and rename continuous_integration.md to continuous-integration.md
* Add line break space content/es/continuous-integration.md

Signed-off-by: Rael Garcia <rael@rael.io>
Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
seokho-son pushed a commit to seokho-son/glossary that referenced this pull request Mar 20, 2023
* CI definition
* Fix typos and word added to dictionary
* Update and rename continuous_integration.md to continuous-integration.md
* Add line break space content/es/continuous-integration.md

Signed-off-by: Rael Garcia <rael@rael.io>
Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/es for Spanish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spanish] localize 'Continuous integration (CI)'
4 participants