-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] CI definition #924
[ADD] CI definition #924
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Muchas gracias @CristianFrancisco85 por traducir el concepto de Integración continua, he dejado un par de observaciones en el documento que me parecen necesarias.
Respecto a los errores reportados por GitHub Actions:
- DCO esto se soluciona firmando los commit messages
git commit -s
- Spellcheck. Es necesario agregar una serie de palabras al diccionario de español. Me parece que las palabras a agregar después de aplicar mis sugerencias serian: Git, Mercurial y Subversion. Generalmente, las agregamos en orden alfabético para fácilmente identificar duplicidad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parece ser que el primer commit no fue firmado, quizá tengas que hacer algo con un rebase interactivo.
Hmmm creo que eso no funciono. Voy a ver como resolver lo de firmar el primer commit |
1f45ccb
to
549e5eb
Compare
@CristianFrancisco85 en general los cambios se ven bien, quizá de mi parte solo sería necesario agregar espacios entre el título y los párrafos traducidos, ya que se está realizando un esfuerzo general por estandarizar esa parte |
@CristianFrancisco85 Thank you for your contribution!
@electrocucaracha @raelga What about your thoughts, as |
I was thinking to use |
@CristianFrancisco85 puedes revisar el comentario #924 (comment) y hacer los cambios en los nombres? |
@electrocucaracha OK then, please edit the commit message suitably when you perform Squash and Merge. :) |
@electrocucaracha Creo que lo mas prudente será hacer otro pull request. |
Si gustas @CristianFrancisco85 , puedo ayudarte con las instrucciones para que no hagas otro PR, es muy sencillo contactame por slack o el martes lo vemos en la junta |
Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com>
Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com>
Signed-off-by: Rael Garcia <rael@rael.io>
Signed-off-by: Rael Garcia <rael@rael.io>
76ac76a
to
04052c1
Compare
* CI definition * Fix typos and word added to dictionary * Update and rename continuous_integration.md to continuous-integration.md * Add line break space content/es/continuous-integration.md Signed-off-by: Rael Garcia <rael@rael.io> Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com> Co-authored-by: Rael Garcia <rael@rael.io>
* CI definition * Fix typos and word added to dictionary * Update and rename continuous_integration.md to continuous-integration.md * Add line break space content/es/continuous-integration.md Signed-off-by: Rael Garcia <rael@rael.io> Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com> Co-authored-by: Rael Garcia <rael@rael.io>
* CI definition * Fix typos and word added to dictionary * Update and rename continuous_integration.md to continuous-integration.md * Add line break space content/es/continuous-integration.md Signed-off-by: Rael Garcia <rael@rael.io> Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com> Co-authored-by: Rael Garcia <rael@rael.io>
* CI definition * Fix typos and word added to dictionary * Update and rename continuous_integration.md to continuous-integration.md * Add line break space content/es/continuous-integration.md Signed-off-by: Rael Garcia <rael@rael.io> Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com> Co-authored-by: Rael Garcia <rael@rael.io>
* CI definition * Fix typos and word added to dictionary * Update and rename continuous_integration.md to continuous-integration.md * Add line break space content/es/continuous-integration.md Signed-off-by: Rael Garcia <rael@rael.io> Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com> Co-authored-by: Rael Garcia <rael@rael.io>
* CI definition * Fix typos and word added to dictionary * Update and rename continuous_integration.md to continuous-integration.md * Add line break space content/es/continuous-integration.md Signed-off-by: Rael Garcia <rael@rael.io> Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com> Co-authored-by: Rael Garcia <rael@rael.io>
* CI definition * Fix typos and word added to dictionary * Update and rename continuous_integration.md to continuous-integration.md * Add line break space content/es/continuous-integration.md Signed-off-by: Rael Garcia <rael@rael.io> Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com> Co-authored-by: Rael Garcia <rael@rael.io>
* CI definition * Fix typos and word added to dictionary * Update and rename continuous_integration.md to continuous-integration.md * Add line break space content/es/continuous-integration.md Signed-off-by: Rael Garcia <rael@rael.io> Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com> Co-authored-by: Rael Garcia <rael@rael.io>
* CI definition * Fix typos and word added to dictionary * Update and rename continuous_integration.md to continuous-integration.md * Add line break space content/es/continuous-integration.md Signed-off-by: Rael Garcia <rael@rael.io> Signed-off-by: Cristian Meoño <cristianfrancisco85@gmail.com> Co-authored-by: Rael Garcia <rael@rael.io>
Based on #581