Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance results for v1.20/openstack-magnum #1320

Merged
merged 1 commit into from
Feb 20, 2021

Conversation

brtkwr
Copy link
Contributor

@brtkwr brtkwr commented Feb 12, 2021

Pre-submission checklist:

Please check each of these after submitting your pull request:

  • If this is a new entry, have you submitted a signed participation form?
  • Did you include the product/project logo in SVG, EPS or AI format?
  • Does your logo clearly state the name of the product/project and follow the other logo guidelines?
  • If your product/project is open source, did you include the repo_url?
  • Did you copy and paste the installation and configuration instructions into the README.md file in addition to linking to them?

@cncf-ci cncf-ci added release-documents-checked All release documents are present and pass all checks release-v1.20 labels Feb 12, 2021
@cncf-ci
Copy link
Collaborator

cncf-ci commented Feb 12, 2021

Found v1.20 in logs

@cncf-ci
Copy link
Collaborator

cncf-ci commented Feb 12, 2021

This conformance request failed to include all of the required tests for v1.20

@cncf-ci
Copy link
Collaborator

cncf-ci commented Feb 12, 2021

The first test found to be mssing was [sig-scheduling] SchedulerPredicates [Serial] validates that there is no conflict between pods with same hostPort but different hostIP and protocol [LinuxOnly] [Conformance]

@riaankleinhans
Copy link
Collaborator

@brtknr the blocking PR merged and that should solve the problem.
Have you pulled in fresh data to include the newly created metadata from the PR before rerunning?

@brtkwr
Copy link
Contributor Author

brtkwr commented Feb 12, 2021

@Riaankl are there instructions for pulling in fresh data anywhere?

@brtkwr
Copy link
Contributor Author

brtkwr commented Feb 12, 2021

is it enough to run sonobuoy again?

@riaankleinhans
Copy link
Collaborator

is it enough to run sonobuoy again?

I believe it would be.

@brtkwr brtkwr force-pushed the v1.20/openstack-magnum branch from 771e2cd to ad4e777 Compare February 12, 2021 12:06
@brtkwr
Copy link
Contributor Author

brtkwr commented Feb 12, 2021

@Riaankl okay I have just pushed the new results

@brtkwr
Copy link
Contributor Author

brtkwr commented Feb 12, 2021

Not sure that made any difference...

@riaankleinhans
Copy link
Collaborator

@brtknr I believe we figured out the issue causing the failure of PR checks.
on 16 Jan, after the release for 1.20 was cut, two commits changed the 1.20 conformance.yaml file.
This cause a mismatch between what you get out of Sonobuoy and that the bot check against the v1.20 .yaml file.
A PR was created to revert these commits, and that should stop the pain we are experiencing.
We will discuss the topic at the next conformance meeting to see how the historical conformance.yaml file should be protected against unwanted change.
Once the PR merge I believe the bot will check are label your PR correctly.

@cncf-ci
Copy link
Collaborator

cncf-ci commented Feb 15, 2021

Automatically verified as having all required tests present and passed

@cncf-ci
Copy link
Collaborator

cncf-ci commented Feb 15, 2021

Automatically verified as having all required tests present and passed

@brtkwr
Copy link
Contributor Author

brtkwr commented Feb 18, 2021

@Riaankl thanks for informing. Looks like this PR has passed.

@taylorwaggoner
Copy link
Contributor

You are now Certified Kubernetes

@taylorwaggoner taylorwaggoner merged commit d24af98 into cncf:master Feb 20, 2021
tnorlin pushed a commit to tnorlin/k8s-conformance that referenced this pull request Dec 6, 2023
devidask27 pushed a commit to platform9/k8s-conformance that referenced this pull request Feb 20, 2024
tnorlin pushed a commit to tnorlin/k8s-conformance that referenced this pull request Oct 25, 2024
tnorlin pushed a commit to tnorlin/k8s-conformance that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants