-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a GitHub Action That Sends a Message to a PR to Notify i18n Tasks. #574
Conversation
Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
✅ Deploy Preview for tag-app-delivery canceled.
|
d4cc797
to
11b247f
Compare
The GitHub Action appears to be non-functional, possibly because this PR was created from a forked repository. I will do a demo on this PR once the problem is resolved. Please wait! 🙏 |
Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
The problem has been resolved...! But, I cannot demonstrate it on this PR for some reason (*).
|
Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Well done @hhiroshell, thanks so much for this! I am sure we will learn more as we go, but this seems like a great start for us including both the logic and the wording.
@hhiroshell are you able to demonstrate the working Action on your own repo or in some other way? |
@lianmakesthings I've demonstrated it in my own repository. please take a look below. |
Thanks @hhiroshell, great work! 👏 |
This PR adds a GitHub Action that sends a message to a PR to notify i18n tasks following the discussion in #537 .
Background
Currently, when adding English content (files under
website/content/en/
), we place a copy in the corresponding directories of other languages. This approach ensures that if there is no translated version available when browsing in different languages, the English content is displayed. Additionally, when updates are made, the same changes need to be applied to the corresponding files in other languages.Our website's i18n support is relatively new, so this task is often overlooked. To prevent such oversights, This PR introduces a GitHub Action that would serve as a reminder.
To reviewers
At the time of opening this PR, the GitHub Action implementation is still in draft, but I would appreciate your feedback on the following points:
website/content/en
and the targets of symbolic links; is there any other area that should be covered?Related Issues and PRs