Add missing picture to the platform whitepaper Chinese version #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node
requested review from
thschue,
joshgav,
lianmakesthings,
kgamanji and
angellk
as code owners
✅ Deploy Preview for tag-app-delivery ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
node
changed the title
lianmakesthings
requested changes
May 11, 2024
lianmakesthings
previously approved these changes
May 13, 2024
lianmakesthings
dismissed
their stale review
Got overexcited. This still requires a review by another native speaker
|
Sincerely invite @rootsongjc to help review this image if he is free. 😄 Also welcome guys from CNCF Cartografos WG to help review. |
roberthstrand
approved these changes
May 28, 2024
|
While it looks technically correct, I will post this is the CNCF Ambassador channel to see if any native speakers could give it a once-over before merging. |
|
Update: |
tao12345666333
suggested changes
May 28, 2024
website/content/zh/wgs/platforms/whitepaper/assets/platforms-def.drawio.zh.xml
Outdated
Show resolved
Hide resolved
website/content/zh/wgs/platforms/whitepaper/assets/platforms-def.drawio.zh.xml
Outdated
Show resolved
Hide resolved
website/content/zh/wgs/platforms/whitepaper/assets/platforms-def.drawio.zh.xml
Outdated
Show resolved
Hide resolved
|
@node, Could you take a look at the comments left by @tao12345666333? I can't really judge whether one word is right or the other, so this is something that I need your help on. |
Signed-off-by: Chris (Gentle) Y杨 <nodexy@gmail.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Chris (Gentle) Y杨 <nodexy@gmail.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
- Alois stepped down as Chair - Lian was voted in and confirmed by TOC - Add Lin Sun as TOC Liaison - Add Alois as Emeritus Lead Signed-off-by: lianmakesthings <hi@lianmakesthings.dev> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: lianmakesthings <hi@lianmakesthings.dev> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: lianmakesthings <hi@lianmakesthings.dev> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: lianmakesthings <hi@lianmakesthings.dev> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: lianmakesthings <hi@lianmakesthings.dev> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Thomas Schuetz <38893055+thschue@users.noreply.github.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Guille Vigil <guille.vigil@bvnk.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Guille Vigil <guille.vigil@bvnk.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Guille Vigil <guille.vigil@bvnk.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Guille Vigil <guille.vigil@bvnk.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
The old link didn't offer me the template as expected. This suggestion should address that, but please check that it works for you like it does for me! Signed-off-by: Marsh Gardiner <marsh.gardiner@gmail.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Marsh Gardiner <marsh.gardiner@gmail.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Chris Abraham <cjyabraham@gmail.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
making both documents consistent Signed-off-by: Marsh Gardiner <marsh.gardiner@gmail.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Marsh Gardiner <marsh.gardiner@gmail.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Abby Bangser <abby@syntasso.io> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Abby Bangser <abby@syntasso.io> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Roberth Strand <me@robstr.dev> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Lian Li <github@chimney42.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Atulpriya Sharma <sharma.atulpriya@gmail.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Chris (Gentle) Y杨 <nodexy@gmail.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Chris (Gentle) Y杨 <nodexy@gmail.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Roberth Strand <me@robstr.dev> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: lianmakesthings <hi@lianmakesthings.dev> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Chris (Gentle) Y杨 <nodexy@gmail.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
…ef.drawio.zh.png Signed-off-by: Chris (Gentle) Y杨 <nodexy@gmail.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Chris (Gentle) Y杨 <nodexy@gmail.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Chris (Gentle) Y杨 <nodexy@gmail.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
New blog submission closes cncf#643 --------- Signed-off-by: Li-Or-Amir <168570997+Li-Or-Amir@users.noreply.github.com> Signed-off-by: Roberth Strand <me@robstr.dev> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Chris (Gentle) Y杨 <nodexy@gmail.com> Signed-off-by: 杨振涛 <10966669@AnotherM2.local>
Signed-off-by: Chris (Gentle) Y杨 <nodexy@gmail.com>
Fixed all of them. Please check it again @tao12345666333 , and thanks for your review. |
roberthstrand
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image translation work is shared at https://docs.google.com/presentation/d/16AeFfd8JG5aJYuTYPn30zNCKiuAnc7hEheRLQwGWHH8/edit?usp=sharing
Refer PR #623