Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: TUF docs Analysis and Improvement #261

Merged
merged 100 commits into from
Aug 9, 2024
Merged

Conversation

Dindihub
Copy link
Collaborator

@Dindihub Dindihub commented Jun 18, 2024

This PR covers issue #162 CNCFSD-1516 Do a first look at the TUF project docs

This is an ongoing exercise so I will be adding content periodically. To see what I'm working on go to analyses/0012-TUF

Maintainers can review routinely and suggest changes.

@nate-double-u
Copy link
Member

Thanks for this, @Dindihub; congrats on your selection to the mentorship program!

I'll let your mentors review this, but we do need each commit to be signed. You can see details on how to do that here: https://github.com/cncf/techdocs/pull/261/checks?check_run_id=26370655815. This, like the formatting workflows, doesn't have to happen right away, but we'll need the commits signed before the PR is approved (and it's easier to manage if you get to it earlier in the process).

/cc @chalin @JustinCappos @lukpueh

@Dindihub
Copy link
Collaborator Author

Thanks for this, @Dindihub; congrats on your selection to the mentorship program!

I'll let your mentors review this, but we do need each commit to be signed. You can see details on how to do that here: https://github.com/cncf/techdocs/pull/261/checks?check_run_id=26370655815. This, like the formatting workflows, doesn't have to happen right away, but we'll need the commits signed before the PR is approved (and it's easier to manage if you get to it earlier in the process).

/cc @chalin @JustinCappos @lukpueh

Noted. Thanks Nate

@Dindihub Dindihub force-pushed the TUF-analysis branch 2 times, most recently from 8460dc8 to 26ecab0 Compare June 19, 2024 17:44
@lukpueh
Copy link

lukpueh commented Jun 21, 2024

Thanks for the great recommendations, @Dindihub! Do you plan to work on any of those? :)

Also, what's the plan for this PR? You say, you want to add content periodically. So it should stay open? I can give it a thorough pass (for typos, etc.) when you think it's ready.

@Dindihub
Copy link
Collaborator Author

Thanks for the great recommendations, @Dindihub! Do you plan to work on any of those? :)

Also, what's the plan for this PR? You say, you want to add content periodically. So it should stay open? I can give it a thorough pass (for typos, etc.) when you think it's ready.

Thanks for asking @lukpueh . I thought to create this PR so you can see what I'm working on. I'll create an implementation soon once @chalin reviews my work.

I'll be sure to notify you and Justin to review once it's ready. I intend for this PR to stay open untill then , so you can review it as a whole. Thanks

@chalin
Copy link
Collaborator

chalin commented Jun 26, 2024

Hi @Dindihub, thanks for the PR, and your patience in getting some feedback. Before we start a formal review, let's get all checks passing (fixing broken links etc), including the DCO requirements, as Nate pointed out. Let me know if you have any questions about how to do that.

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dindihub - let's change the naming convention for the pages in this project. Specifically, rename the TUF-abc.md files by dropping the TUF- prefix.

(Using a prefix made sense when the analysis was in a single file, but not here.)

The rename might also fix some of the broken links.

@Dindihub
Copy link
Collaborator Author

Hi @Dindihub, thanks for the PR, and your patience in getting some feedback. Before we start a formal review, let's get all checks passing (fixing broken links etc), including the DCO requirements, as Nate pointed out. Let me know if you have any questions about how to do that.

Thanks for the review @chalin. Let me work on it again. I have some questions about DCO for you on Slack. Thanks

@Dindihub
Copy link
Collaborator Author

@Dindihub - let's change the naming convention for the pages in this project. Specifically, rename the TUF-abc.md files by dropping the TUF- prefix.

(Using a prefix made sense when the analysis was in a single file, but not here.)

The rename might also fix some of the broken links.

Noted. Thanks @chalin

@chalin chalin marked this pull request as draft June 27, 2024 17:17
@chalin
Copy link
Collaborator

chalin commented Jun 27, 2024

@Dindihub - for each of the failed PR checks, click on Details at the extreme right to see the run log for any specific failed check.

For example, if you visit https://github.com/cncf/techdocs/actions/runs/9693237225/job/26773151326?pr=261, you'll see:

Run npm run check:format

> techdocs@0.0.0 check:format
> npm run _check:format || (echo '[help] Run: npm run fix:format'; exit 1)


> techdocs@0.0.0 _check:format
> npx prettier --check .

npm warn exec The following package was not found and will be installed: prettier@3.3.2
Checking formatting...
[warn] analyses/00[12](https://github.com/cncf/techdocs/actions/runs/9693237225/job/26773151326?pr=261#step:4:13)-TUF/analysis.md
[warn] analyses/0012-TUF/implementation.md
[warn] Code style issues found in 2 files. Run Prettier with --write to fix.
[help] Run: npm run fix:format
Error: Process completed with exit code 1.

Notice the [help] line tells you which command to run on your local machine to fix the formatting issues.

Fix the formatting first (using npm run fix:format) and that will address many (if not all) of the markdown check failures.

@Dindihub
Copy link
Collaborator Author

Dindihub commented Jun 28, 2024

@Dindihub - for each of the failed PR checks, click on Details at the extreme right to see the run log for any specific failed check.

For example, ...
Notice the [help] line tells you which command to run on your local machine to fix the formatting issues.

Fix the formatting first (using npm run fix:format) and that will address many (if not all) of the markdown check failures.

Ah. Noted. Thanks

@chalin chalin force-pushed the TUF-analysis branch 2 times, most recently from cafde37 to 2a898f8 Compare June 30, 2024 23:28
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Dindihub and others added 23 commits July 30, 2024 15:52
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Signed-off-by: Dindihub <100135497+Dindihub@users.noreply.github.com>
Co-authored-by: Charles Uneze <charlesniklaus@gmail.com>
Signed-off-by: Dindihub <100135497+Dindihub@users.noreply.github.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Co-authored-by: Charles Uneze <charlesniklaus@gmail.com>
Signed-off-by: Dindihub <100135497+Dindihub@users.noreply.github.com>
Co-authored-by: Charles Uneze <charlesniklaus@gmail.com>
Signed-off-by: Dindihub <100135497+Dindihub@users.noreply.github.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Co-authored-by: Charles Uneze <charlesniklaus@gmail.com>
Signed-off-by: Dindihub <100135497+Dindihub@users.noreply.github.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
@chalin chalin marked this pull request as ready for review August 9, 2024 00:00
Signed-off-by: Patrice Chalin <chalin@users.noreply.github.com>
analyses/0012-TUF/README.md Outdated Show resolved Hide resolved
Signed-off-by: Patrice Chalin <chalin@users.noreply.github.com>
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

Let's merge; we can always make adjustments as we discover necessary edits.

@chalin chalin merged commit c5e5b36 into cncf:main Aug 9, 2024
5 checks passed
Dindihub added a commit to Dindihub/TUF-docs-analysis that referenced this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs analysis CNCF technical documentation assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants