-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: TUF docs Analysis and Improvement #261
Conversation
Thanks for this, @Dindihub; congrats on your selection to the mentorship program! I'll let your mentors review this, but we do need each commit to be signed. You can see details on how to do that here: https://github.com/cncf/techdocs/pull/261/checks?check_run_id=26370655815. This, like the formatting workflows, doesn't have to happen right away, but we'll need the commits signed before the PR is approved (and it's easier to manage if you get to it earlier in the process). |
Noted. Thanks Nate |
8460dc8
to
26ecab0
Compare
Thanks for the great recommendations, @Dindihub! Do you plan to work on any of those? :) Also, what's the plan for this PR? You say, you want to add content periodically. So it should stay open? I can give it a thorough pass (for typos, etc.) when you think it's ready. |
Thanks for asking @lukpueh . I thought to create this PR so you can see what I'm working on. I'll create an implementation soon once @chalin reviews my work. I'll be sure to notify you and Justin to review once it's ready. I intend for this PR to stay open untill then , so you can review it as a whole. Thanks |
Hi @Dindihub, thanks for the PR, and your patience in getting some feedback. Before we start a formal review, let's get all checks passing (fixing broken links etc), including the DCO requirements, as Nate pointed out. Let me know if you have any questions about how to do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dindihub - let's change the naming convention for the pages in this project. Specifically, rename the TUF-abc.md
files by dropping the TUF-
prefix.
(Using a prefix made sense when the analysis was in a single file, but not here.)
The rename might also fix some of the broken links.
Thanks for the review @chalin. Let me work on it again. I have some questions about DCO for you on Slack. Thanks |
Noted. Thanks @chalin |
@Dindihub - for each of the failed PR checks, click on Details at the extreme right to see the run log for any specific failed check. For example, if you visit https://github.com/cncf/techdocs/actions/runs/9693237225/job/26773151326?pr=261, you'll see:
Notice the Fix the formatting first (using |
Ah. Noted. Thanks |
cafde37
to
2a898f8
Compare
Signed-off-by: Dindihub <sadindi03@gmail.com> Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com> Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com> Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com> Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com> Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com> Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com> Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com> Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com> Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com> Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com> Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com> Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com> Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Dindihub <100135497+Dindihub@users.noreply.github.com>
Co-authored-by: Charles Uneze <charlesniklaus@gmail.com> Signed-off-by: Dindihub <100135497+Dindihub@users.noreply.github.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Co-authored-by: Charles Uneze <charlesniklaus@gmail.com> Signed-off-by: Dindihub <100135497+Dindihub@users.noreply.github.com>
Co-authored-by: Charles Uneze <charlesniklaus@gmail.com> Signed-off-by: Dindihub <100135497+Dindihub@users.noreply.github.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Co-authored-by: Charles Uneze <charlesniklaus@gmail.com> Signed-off-by: Dindihub <100135497+Dindihub@users.noreply.github.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Dindihub Dindi <sadindi03@gmail.com>
Signed-off-by: Patrice Chalin <chalin@users.noreply.github.com>
Signed-off-by: Patrice Chalin <chalin@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✨
Let's merge; we can always make adjustments as we discover necessary edits.
This PR covers issue #162 CNCFSD-1516 Do a first look at the TUF project docs
This is an ongoing exercise so I will be adding content periodically. To see what I'm working on go to analyses/0012-TUF
Maintainers can review routinely and suggest changes.