Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/orca: migrate ORCA protos to cncf/udpa with skeleton build system. #1

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

htuch
Copy link
Collaborator

@htuch htuch commented Aug 21, 2019

The build system in this PR is largely derived from a minified variant of https://github.com/envoyproxy/envoy/tree/master/api/bazel.

The dependency management is intended to support a minimal standalone build of the UDPA protos and their tests. Consuming projects (e.g. Envoy) will continue to manage dependencies, e.g. gRPC, protobuf, PGV, independently of the repository macros in this PR; over time we may be able to factor out some common concerns.

Signed-off-by: Harvey Tuch htuch@google.com

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch
Copy link
Collaborator Author

htuch commented Aug 21, 2019

@mattklein123 @lizan for review. At a bare minimum, we need to add CI to this PR (or an immediate followup) and also check/fix_format. We had to do a lot of forking from Envoy to make this work with Nighthawk, if you have any other better ideas (a common utilities repo?) I'm all ears.

I have an Envoy branch with the WiP for integrating at https://github.com/htuch/envoy/tree/cncf-udap.

@mattklein123
Copy link
Collaborator

We had to do a lot of forking from Envoy to make this work with Nighthawk, if you have any other better ideas (a common utilities repo?) I'm all ears.

I think this came up for envoy-mobile also. I think we should definitely look into doing a common utility repo for shared build tools. WDYT?

Copy link
Collaborator

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which parts of this are copied vs. new? I'm trying to figure out what to review here. :)

@htuch
Copy link
Collaborator Author

htuch commented Aug 22, 2019

Basically everything is copied and slimmed down. Maybe an efficient way to do this is to download and just diff individual files against the api/ equivalent in envoyproxy/envoy.

Re: shared repo. Agree. What I can do is work on that as a next step; we can basically do this PR to get a baseline. Then a CI PR to get some basic tests happening and followup with a format PR that introduces the script from a common repo.

Copy link
Collaborator

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just going to trust you on the copying and slimming. If you want me to review any specific changes can you let me know and/or just put the original files as an earlier commit in this PR?

@htuch htuch merged commit 4cbdcb9 into cncf:master Aug 22, 2019
@htuch htuch deleted the udpa-proto-setup branch August 22, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants