Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest_install: Move manifest install to cnf-testsuite #3

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

kosstennbl
Copy link
Contributor

Manifest installation method doesn't have anything common with helm Because of that it should be moved to cnf-testsuite repo. Also, InstallMethod-related code was also moved as its usage is specific to cnf-testsuite.

Refs: #2105 (cnti-testcatalog/testsuite#2105)

Manifest installation method doesn't have anything common with helm
Because of that it should be moved to cnf-testsuite repo.
Also, InstallMethod-related code was also moved as its usage is
specific to cnf-testsuite.

Refs: #2105
Signed-off-by: Konstantin Yarovoy <konstantin.yarovoy@tietoevry.com>
@kosstennbl kosstennbl marked this pull request as draft July 22, 2024 08:40
@kosstennbl
Copy link
Contributor Author

kosstennbl commented Jul 22, 2024

Should wait for the merge of cnti-testcatalog/testsuite#2111

@kosstennbl kosstennbl marked this pull request as ready for review July 25, 2024 08:04
Copy link
Contributor

@martin-mat martin-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@horecoli horecoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine.

Copy link

@rich-l rich-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@taylor
Copy link
Contributor

taylor commented Aug 30, 2024

Bump.

Should wait for the merge of cnti-testcatalog/testsuite#2111

Merged

@martin-mat martin-mat merged commit ae6c3a3 into cnf-testsuite:main Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants