partial Dev dpi system -> do not merge #703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efore CreateWindowEx
…ent not winndows dependent
…angle, round_rectangle
# Conflicts: # include/nana/gui/detail/bedrock.hpp # include/nana/gui/drawing.hpp # include/nana/gui/screen.hpp # include/nana/gui/widgets/button.hpp # include/nana/gui/widgets/form.hpp # include/nana/gui/widgets/listbox.hpp # include/nana/gui/widgets/treebox.hpp # include/nana/gui/widgets/widget.hpp # include/nana/paint/graphics.hpp # include/nana/paint/pixel_buffer.hpp # source/detail/platform_abstraction.hpp # source/gui/detail/basic_window.cpp # source/gui/detail/basic_window.hpp # source/gui/detail/bedrock_pi.cpp # source/gui/detail/inner_fwd_implement.hpp # source/gui/detail/window_manager.cpp # source/gui/drawing.cpp # source/gui/place.cpp # source/gui/place_parts.hpp # source/gui/screen.cpp # source/gui/widgets/menu.cpp # source/gui/widgets/menubar.cpp # source/gui/widgets/skeletons/content_view.cpp # source/gui/widgets/treebox.cpp # source/paint/detail/native_paint_interface.cpp # source/paint/graphics.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEFORE merge this (please, set IGNORE whitespaces !! those are just for doxy-docs and readability ):
I have no possibility of debugging.
change_scale(float new_scale)/change_dpi(int new_dpi)This compile in Ubuntu (in GitHub actions with GCC 13; and in WSL2 with GCC11 using Eclipse/cmake)
In Windows 10 (MSVC2022 and MinGW with GCC 13) - run OK by dpi 96, and ALREADY solve some problems by dpi change !!
But there is a lot to do: see #698, in To Do
graphicskeep the target dpi: every singlegraphicsneed to.set_dpi(new_dpi)after a windows change the dpi and before refresh !!.change_dpi(new_dpi)inwidget,widget_base,widget_objectandbasic_windowthat apply.set_dpi(new_dpi)to everygraphics??bitblt,pasteandstretchcheck that the src and dst have the same target dpi to decide to use a 'paste' or to do instead 'stretch' before.bitblt,pasteandstretchgraphicsall around nana set the correct target dpi before drawing and 'paste' and that only US coordinate are passed to it. (takegraphicsfromapi::window_graphics(window wd)? or take the dpi of wd and pass to the newgraphics)animation(set by user? make it clear in api docs?), butanimation::implcreate one more :framegraphdrawing.draw(set by user? make it clear in api docs?)drawer.draw(set by user? make it clear in api docs?) - implementdrawing::drawnana::effects/bground_interfacenana::element/graph_referenceinelement_abstract,facade,cite_bground,bgroundplaceinsplitter_rendererdrawer_triggerin basedrawerkeep agraphics.api::copy_transparent_background,glass_buffernana::element::bground::draw_graphnana::paint::graphics nana::element::bground::draw_graph::graphnana::paint::graphics nana::widgets::skeletons::text_editor::implementation::inner_counterpart::buffermsgboxico_ X11nana::paint::graphics nana::place::implement::div_dockpane::indicator_rep::graphpixel_bufferall around nana only System-side (SS) coordinate are passed to it. If this is not possible or desired, use only US (don't mix US and SS !!) and do a stretch at the end, instead of paste.#701, #702 and #698 may help to get an idea.