Fixed bug when APPROXNORM == 1 is used when CCEMBEDDED is not defined… #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (ie colorchord2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Charles,
I'm able to run colorchord2 again (libudev.h somehow went missing, I had to apt-get install libudev-dev). I tested both with colorchord2 default and embedded8266 version.
I read up on right bit shifting a negative integer and apparently it is implementation dependent, so the code is now slightly rearranged so it shifts non-negative values.
I used grep to search all the code in colorchord2 and embeddedbins32 is never used.
Could a return be added after
goutbins[i] /= (78<<DFTIIR)*(1<<octave);