refactor: mail #49
Merged
refactor: mail #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinchang
force-pushed
the
feat/common-email
branch
from
41410af to
767808c
Compare
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 59.17% 59.49% +0.31%
==========================================
Files 33 34 +1
Lines 926 958 +32
==========================================
+ Hits 548 570 +22
- Misses 378 388 +10
Continue to review full report at Codecov.
|
JacksonTian
requested changes
Mar 8, 2018
config/config.default.js
Outdated
| // debug 为 true 时，用于本地调试 | ||
| config.debug = true; | ||
|
|
||
| // use for cookie sign key, should change to your own and keep security | ||
| config.keys = appInfo.name + '_1519887194138_3450'; | ||
| config.keys = '_1519887194138_3450'; |
package.json
Outdated
| @@ -4,6 +4,7 @@ | |||
| "description": "", | |||
| "private": true, | |||
| "dependencies": { | |||
| "async-retry": "^1.2.1", | |||
package.json
Outdated
| @@ -18,6 +19,9 @@ | |||
| "loader-koa": "^2.0.1", | |||
| "lodash": "^4.17.5", | |||
| "markdown-it": "^8.4.1", | |||
| "nodemailer": "^4.6.2", | |||
| "nodemailer-smtp-transport": "^2.7.4", | |||
| "util": "^0.10.3", | |||
There was a problem hiding this comment.
const from = util.format('%s <%s>', config.name, config.mail_opts.auth.user); 用在这，看老 cnode 是这么写的。
app/common/mail.js
Outdated
| const mailer = require('nodemailer'); | ||
| const smtpTransport = require('nodemailer-smtp-transport'); | ||
| const util = require('util'); | ||
| const config = require('../../config/config.default')(); |
There was a problem hiding this comment.
这个不能这样用的。如果不行的话 我们把 mail 的功能放进 service 里好了。
There was a problem hiding this comment.
移动到 service 去做，这样 config logger 都可以拿到了，不需要做 plugin 了。
sinchang
force-pushed
the
feat/common-email
branch
from
acc1f39 to
63d9beb
Compare
JacksonTian
approved these changes
Mar 9, 2018
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: issue #14
Checklist
npm testpassesAffected core subsystem(s)
common services
Description of change
common mail method