Skip to content

Fixing Bug with KeyCloak Ingress #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elamaran11
Copy link
Contributor

Fixing Bug with KeyCloak Ingress

Signed-off-by: Elamaran Shanmugam <elamaran.shan@gmail.com>
@nabuskey
Copy link
Contributor

nabuskey commented Sep 5, 2024

It's my bad for not documenting this but it's actually intentional that the service is configured that way. It's a way to ensure keycloak admin console and master realms are not accessible. See this for more information: https://www.keycloak.org/server/configuration-production

I know we are not doing this for production but I do want to follow minimum security measures when exposing things to the internet.

@elamaran11
Copy link
Contributor Author

Understood, IMO you can expose it for reference implementation and add notes to say for prod scenarios this is not recommended. I was blind and have to spend some time to fix for my impl. Worst case the paths should be removed vs having wrong port 8081

@nabuskey
Copy link
Contributor

nabuskey commented Sep 6, 2024

I see. I should have documented that.

How about we add a switch in Terraform to enable this? Set default not enabled. If users want to have this, they have to change the value themselves. We can put a comment in there and warn users.

@elamaran11
Copy link
Contributor Author

Ya thats very fair. I can make that code change sometime and also add comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants