fix: not exists binary should return 404 (#377)

closes #376
cnpm · Jan 18, 2023 · 0cc348d · 0cc348d
1 parent 7952e33
commit 0cc348d
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/app/port/controller/BinarySyncController.ts b/app/port/controller/BinarySyncController.ts
@@ -51,6 +51,9 @@ export class BinarySyncController extends AbstractController {
     method: HTTPMethodEnum.GET,
   })
   async showBinary(@Context() ctx: EggContext, @HTTPParam() binaryName: string, @HTTPParam() subpath: string) {
+    if (!binaries[binaryName]) {
+      throw new NotFoundError(`Binary "${binaryName}" not found`);
+    }
     subpath = subpath || '/';
     if (subpath === '/') {
       const items = await this.binarySyncerService.listRootBinaries(binaryName);

diff --git a/test/port/controller/BinarySyncController/showBinary.test.ts b/test/port/controller/BinarySyncController/showBinary.test.ts
@@ -82,6 +82,27 @@ describe('test/port/controller/BinarySyncController/showBinary.test.ts', () => {
         url: 'http://localhost:7001/-/binary/nwjs/',
       }]);
     });
+
+    it('should 404 when binary not exists', async () => {
+      let res = await app.httpRequest()
+        .get('/-/binary/node-canvas-prebuilt-not-exists/');
+      assert.equal(res.status, 404);
+      assert.equal(res.headers['content-type'], 'application/json; charset=utf-8');
+      assert.deepEqual(res.body, { error: '[NOT_FOUND] Binary "node-canvas-prebuilt-not-exists" not found' });
+
+      res = await app.httpRequest()
+        .get('/-/binary/node-canvas-prebuilt-not-exists/v2.6.1/');
+      assert.equal(res.status, 404);
+      assert.equal(res.headers['content-type'], 'application/json; charset=utf-8');
+      assert.deepEqual(res.body, { error: '[NOT_FOUND] Binary "node-canvas-prebuilt-not-exists" not found' });
+
+      res = await app.httpRequest()
+        .get('/-/binary/node-canvas-prebuilt-not-exists/v2.6.1/foo.json');
+      assert.equal(res.status, 404);
+      assert.equal(res.headers['content-type'], 'application/json; charset=utf-8');
+      assert.deepEqual(res.body, { error: '[NOT_FOUND] Binary "node-canvas-prebuilt-not-exists" not found' });
+    });
+
     it('should show valid sub dirs', async () => {
       await binaryRepository.saveBinary(Binary.create({
         category: 'node-canvas-prebuilt',
@@ -103,8 +124,8 @@ describe('test/port/controller/BinarySyncController/showBinary.test.ts', () => {
         type: 'dir',
         url: 'http://localhost:7001/-/binary/node-canvas-prebuilt/v2.6.1/',
       }]);
-
     });
+
     it('should show valid files', async () => {
       await binaryRepository.saveBinary(Binary.create({
         category: 'node-canvas-prebuilt',