🤖 TEST: show package not use cache if isSync (#273)

tests for #268
cnpm · Jul 25, 2022 · 3268d03 · 3268d03
1 parent 86e7fc6
commit 3268d03
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/app/common/SyncUtil.ts b/app/common/SyncUtil.ts
@@ -6,7 +6,7 @@ export function isSyncWorkerRequest(ctx: EggContext) {
   if (!isSyncWorkerRequest) {
     const ua = ctx.headers['user-agent'] || '';
     // old sync client will request with these user-agent
-    if (ua.indexOf('npm_service.cnpmjs.org/') !== -1) {
+    if (ua.includes('npm_service.cnpmjs.org/')) {
       isSyncWorkerRequest = true;
     }
   }

diff --git a/test/port/controller/package/ShowPackageController.test.ts b/test/port/controller/package/ShowPackageController.test.ts
@@ -112,6 +112,22 @@ describe('test/port/controller/package/ShowPackageController.test.ts', () => {
         .set('If-None-Match', res.headers.etag)
         .expect('vary', 'Origin')
         .expect(304);
+      // ignore sync request
+      res2 = await app.httpRequest()
+        .get(`/${name}?cache=0`)
+        .set('If-None-Match', res.headers.etag)
+        .expect('vary', 'Origin')
+        .expect(200);
+      assert(res2.body.name);
+      assert.equal(res2.headers.etag, res.headers.etag);
+      res2 = await app.httpRequest()
+        .get(`/${name}`)
+        .set('If-None-Match', res.headers.etag)
+        .set('user-agent', 'npm_service.cnpmjs.org/1.0.0')
+        .expect('vary', 'Origin')
+        .expect(200);
+      assert(res2.body.name);
+      assert.equal(res2.headers.etag, res.headers.etag);
 
       mock(app.config.cnpmcore, 'enableCDN', true);
       await app.httpRequest()