Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: diff #698

Closed
fengmk2 opened this issue Jun 13, 2024 · 2 comments · Fixed by #699
Closed

perf: diff #698

fengmk2 opened this issue Jun 13, 2024 · 2 comments · Fixed by #699
Assignees
@elrrrrrrr

Comments

@fengmk2
Copy link
Member

fengmk2 commented Jun 13, 2024

application/app/core/service/BinarySyncerService.js:221
image
@fengmk2
Copy link
Member Author

fengmk2 commented Jun 13, 2024

https://github.com/cnpm/cnpmcore/blob/master/app/core/service/BinarySyncerService.ts#L279
image

@fengmk2 fengmk2 mentioned this issue Jun 13, 2024
Merged
@elrrrrrrr elrrrrrrr self-assigned this Jun 13, 2024
@elrrrrrrr elrrrrrrr mentioned this issue Jun 13, 2024
Merged
@elrrrrrrr
Copy link
Member

#647 (comment)

我梦到过这段

fengmk2 pushed a commit that referenced this issue Jun 14, 2024
@elrrrrrrr
fix: perf diff (#699)
753e519 
> optimize binary sync perf , closes #698 
* ♻️ calculate the latestItem only once for the same fetchItems.
--------
> binary 同步性能优化，close #698

* ♻️ binary 最新版本比对时，相同 fetchItems 仅计算一次。

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Improved logic for identifying the latest item in synchronization
processes, ensuring more accurate date comparisons.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
fengmk2 pushed a commit that referenced this issue Jun 14, 2024
@semantic-release-bot
Release 3.61.4
571d265 
[skip ci]

## [3.61.4](v3.61.3...v3.61.4) (2024-06-14)

### Bug Fixes

* perf diff ([#699](#699)) ([753e519](753e519)), closes [#698](#698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elrrrrrrr elrrrrrrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: perf diff cnpm/cnpmcore
2 participants
@fengmk2 @elrrrrrrr