Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add type for exports #248

Merged
merged 1 commit into from
Jun 20, 2022
Merged

feat: add type for exports #248

merged 1 commit into from
Jun 20, 2022

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Jun 17, 2022

should use with "moduleResolution": "NodeNext".

should use with `"moduleResolution": "NodeNext"`.
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #248 (fbb7f46) into main (03a8507) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   97.21%   97.16%   -0.06%     
==========================================
  Files         119      119              
  Lines        3632     3632              
  Branches      320      320              
==========================================
- Hits         3531     3529       -2     
- Misses        101      103       +2     
Impacted Files Coverage Δ
app/common/adapter/binary/PlaywrightBinary.ts 94.11% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03a8507...fbb7f46. Read the comment docs.

Copy link
Member

@gemwuu gemwuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu killagu merged commit 66b411e into main Jun 20, 2022
@killagu killagu deleted the feat/exports_type branch June 20, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants