Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changes stream #297

Merged
merged 1 commit into from
Aug 24, 2022
Merged

fix: changes stream #297

merged 1 commit into from
Aug 24, 2022

Conversation

elrrrrrrr
Copy link
Member

  1. 修复 registry/sync 初始化时没有传递 registryId 问题
  2. 修复 changesStream 获取时,如果没有需要同步的任务会导致 task#since 无法更新

@elrrrrrrr elrrrrrrr requested review from gemwuu and killagu August 24, 2022 06:39
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #297 (7d809ef) into main (304014c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files         149      149           
  Lines        4470     4472    +2     
  Branches      370      370           
=======================================
+ Hits         4313     4315    +2     
  Misses        157      157           
Impacted Files Coverage Δ
app/core/entity/Task.ts 100.00% <100.00%> (ø)
app/core/service/ChangesStreamService.ts 100.00% <100.00%> (ø)
app/core/service/RegistryManagerService.ts 100.00% <100.00%> (ø)
app/repository/model/HistoryTask.ts 100.00% <100.00%> (ø)
app/repository/model/PackageVersionBlock.ts 100.00% <100.00%> (ø)
app/repository/model/Task.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@gemwuu gemwuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gemwuu gemwuu merged commit 359a150 into main Aug 24, 2022
@gemwuu gemwuu deleted the fix-changes-stream branch August 24, 2022 07:54
@killagu
Copy link
Contributor

killagu commented Aug 24, 2022

+ cnpmcore@1.11.1

@elrrrrrrr elrrrrrrr added the bug Something isn't working label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants