fix: changesStream suspend #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
elrrrrrrr
commented
Feb 15, 2023
elrrrrrrr
commented
- 修改 app 内 Service 获取方式
- 移除废弃的 typing.ts 声明
- Update Service init logic in appHook
- Remove the deprecated typing.ts
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
==========================================
- Coverage 97.60% 97.43% -0.17%
==========================================
Files 151 150 -1
Lines 13268 13261 -7
Branches 2060 2054 -6
==========================================
- Hits 12950 12921 -29
- Misses 318 340 +22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fengmk2
reviewed
Feb 15, 2023
| await ctx.module.cnpmcoreCore.changesStreamService.suspendTaskWhenExit(); | ||
| }); | ||
| }); | ||
| const changesStreamService = await this.app.getEggObject(ChangesStreamService); |
There was a problem hiding this comment.
@killagu egg 生命周期里面也可以注入 singleton 对象？
fengmk2
approved these changes
Feb 15, 2023
fengmk2
pushed a commit
that referenced
this pull request
Feb 15, 2023
[skip ci] ## [3.4.3](v3.4.2...v3.4.3) (2023-02-15) ### Bug Fixes * changesStream suspend ([#408](#408)) ([2c821ea](2c821ea))
|
🎉 This PR is included in version 3.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.