fix: should close app on afterAll hook #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
commented
Feb 15, 2023
Codecov ReportBase: 85.72% // Head: 55.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
===========================================
- Coverage 85.72% 55.41% -30.31%
===========================================
Files 27 24 -3
Lines 2571 2501 -70
Branches 464 173 -291
===========================================
- Hits 2204 1386 -818
- Misses 367 1115 +748
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fengmk2
pushed a commit
that referenced
this pull request
Feb 16, 2023
[skip ci] ## [5.10.5](v5.10.4...v5.10.5) (2023-02-16) ### Bug Fixes * should close app on afterAll hook ([#158](#158)) ([081b157](081b157))
|
🎉 This PR is included in version 5.10.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
mocha parallel mode 下，afterAll 会在每个 test file 执行完成之后执行一次。这里不能关闭。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cnpm/cnpmcore#408 avoid app beforeClose logic not coverage problem