Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Auto set China mirror for prebuild binary packages #47

Merged
merged 2 commits into from
Mar 9, 2016
Merged

feat: Auto set China mirror for prebuild binary packages #47

merged 2 commits into from
Mar 9, 2016

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Mar 8, 2016

closes #45

@fengmk2 fengmk2 added this to the 1.x milestone Mar 8, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @dead-horse to be a potential reviewer

@fengmk2
Copy link
Member Author

fengmk2 commented Mar 8, 2016

sqlite3 安装不再痛苦

image

@fengmk2
Copy link
Member Author

fengmk2 commented Mar 8, 2016

人肉测试通过

image

@fengmk2 fengmk2 force-pushed the support-prebuild-binary-mirror branch from a79db16 to 4d75ee3 Compare March 8, 2016 17:34
@codecov-io
Copy link

Current coverage is 93.39%

Merging #47 into master will decrease coverage by -0.71% as of fe0fb6b

@@            master     #47   diff @@
======================================
  Files           18      18       
  Stmts          746     757    +11
  Branches       128     133     +5
  Methods          0       0       
======================================
+ Hit            702     707     +5
  Partial          0       0       
- Missed          44      50     +6

Review entire Coverage Diff as of fe0fb6b

Powered by Codecov. Updated on successful CI builds.

fengmk2
fengmk2 reviewed Mar 8, 2016
View reviewed changes
lib/prebuild_mirror_config_china.json
@@ -0,0 +1,41 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This the hard way we're living in China.

@fengmk2
Copy link
Member Author

fengmk2 commented Mar 9, 2016

Done

dead-horse added a commit that referenced this pull request Mar 9, 2016
@dead-horse
Merge pull request #47 from cnpm/support-prebuild-binary-mirror
b6d35d1 
feat: Auto set China mirror for prebuild binary packages
@dead-horse dead-horse merged commit b6d35d1 into master Mar 9, 2016
@dead-horse dead-horse deleted the support-prebuild-binary-mirror branch March 9, 2016 04:06
@fengmk2
Copy link
Member Author

fengmk2 commented Mar 9, 2016

1.3.0

@popomore popomore mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dead-horse dead-horse

Labels
enhancement
Projects
None yet
Milestone
1.x
Development

Successfully merging this pull request may close these issues.

Support prebuild mirrors config
4 participants
@fengmk2 @mention-bot @codecov-io @dead-horse