Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Disable automatic execution of uninstall k3s function #504

Closed
kingsd041 opened this issue Sep 23, 2022 · 4 comments
Closed
Labels
documentation Improvements or additions to documentation feature New feature or request to test Need to test
Milestone

Comments

@kingsd041
Copy link

If autok3s fails to create a k3s cluster, the unloading logic will be executed automatically. In this way, the error log of k3s cannot be viewed, and the cause of the problem cannot be checked, as shown in the following figure:

image

We should limit the automatic execution of the uninstallation logic by parameters, so that we can connect to the host and view the error log of K3s.

We should also remind users that the cluster created by this mode is only suitable for troubleshooting, and if it fails, the k3s cluster needs to be uninstalled manually.

@orangedeng
Copy link
Member

Tested with creating cluster via wrong master args. While setting --rollback=false, the cluster won't rollback after creation failed. And deleting cluster will run the rollback logic.

@orangedeng
Copy link
Member

Maybe we need to expose this feature to web UI also. And we need to update docs for this too.

@JacieChao
Copy link
Collaborator

Yes. We already add a debug button on UI in create cluster form. Will update docs for this feature after UI commit merged.

@orangedeng
Copy link
Member

orangedeng commented Aug 21, 2023

Already tested with CLI and webUI, no rollback function works as expected. Test Passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature or request to test Need to test
Development

No branches or pull requests

3 participants