fix(autok3s): Support disabling rollback in API #622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently disabling rollback only works in CLI. To change the field to string to support it in API.
JacieChao
reviewed
Aug 14, 2023
There was a problem hiding this comment.
I recommend adding a bool type check here instead of changing the field type because there are other kinds of bool type fields also in cluster struct.
|
Closing this PR as it will be fixed in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently disabling rollback only works in CLI. To change the field to string to support it in API.
The root cause is
MergeConfigfrompkg/utils/util.go. If setting rollback to boolfalse, it won't be set to sourceConfig as it is zero value of bool type. By changing it to string to fix it.Refer to #504