Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes for public version code #147

Closed
3 tasks done
bherr2 opened this issue Apr 22, 2024 · 0 comments
Closed
3 tasks done

Minor fixes for public version code #147

bherr2 opened this issue Apr 22, 2024 · 0 comments
Assignees
@edlu77

Comments

@bherr2
Copy link
Member

bherr2 commented Apr 22, 2024 •
edited by edlu77
Loading

  • Put a comment in isPublic that says specifically what file its looking for (its ok that the code uses a config, but it is likely to never change, so a comment is appropriate for maintainers)
  • An error is logged to the console when aggregate-table-data.json is missing (the one that indicates it's public/private). Handle it in a way that does not produce an error (you could fetch it as text instead of JSON for instance)
  • Fix graphical glitch in the menu when in public mode (the line is extra thick where the menu items have been removed)

Error (chrome):

{
  "headers": {
    "normalizedNames": {},
    "lazyUpdate": null
  },
  "status": 200,
  "statusText": "OK",
  "url": "https://node.cns.iu.edu/client/a2agc/staging/assets/generated/aggregate-table-data.json",
  "ok": false,
  "name": "HttpErrorResponse",
  "message": "Http failure during parsing for https://node.cns.iu.edu/client/a2agc/staging/assets/generated/aggregate-table-data.json",
  "error": {
    "error": {},
    "text": "<!DOCTYPE html><html lang=\"en\"><head><link rel=\"preconnect\" href=\"https://fonts.gstatic.com\" crossorigin=\"\">\n  <meta charset=\"utf-8\">\n  <title>Indiana Opioid Dashboard</title>\n  <base href=\"/client/a2agc/\">\n  <meta name=\"viewport\" content=\"width=device-width, initial-scale=1\">\n  <link rel=\"icon\" type=\"image/x-icon\" href=\"favicon.ico\">\n  <style type=\"text/css\">@font-face{font-family:'Lato';font-style:normal;font-weight:300;font-display:swap;src:url(https://fonts.gstatic.com/s/lato/v23/S6u9w4BMUTPHh7USSwaPGQ3q5d0N7w.woff2) format('woff2');unicode-range:U+0100-024F, U+0259, U+1E00-1EFF, U+2020, U+20A0-20AB, U+20AD-20CF, U+2113, U+2C60-2C7F, U+A720-A7FF;}@font-face{font-family:'Lato';font-style:normal;font-weight:300;font-display:swap;src:url(https://fonts.gstatic.com/s/lato/v23/S6u9w4BMUTPHh7USSwiPGQ3q5d0.woff2) format('woff2');unicode-range:U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;}@font-face{font-family:'Lato';font-style:normal;font-weight:400;font-display:swap;src:url(https://fonts.gstatic.com/s/lato/v23/S6uyw4BMUTPHjxAwXiWtFCfQ7A.woff2) format('woff2');unicode-range:U+0100-024F, U+0259, U+1E00-1EFF, U+2020, U+20A0-20AB, U+20AD-20CF, U+2113, U+2C60-2C7F, U+A720-A7FF;}@font-face{font-family:'Lato';font-style:normal;font-weight:400;font-display:swap;src:url(https://fonts.gstatic.com/s/lato/v23/S6uyw4BMUTPHjx4wXiWtFCc.woff2) format('woff2');unicode-range:U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;}</style>\n  <style type=\"text/css\">@font-face{font-family:'Material Icons';font-style:normal;font-weight:400;src:url(https://fonts.gstatic.com/s/materialicons/v135/flUhRq6tzZclQEJ-Vdg-IuiaDsNcIhQ8tQ.woff2) format('woff2');}@font-face{font-family:'Material Icons Outlined';font-style:normal;font-weight:400;src:url(https://fonts.gstatic.com/s/materialiconsoutlined/v107/gok-H7zzDkdnRel8-DQ6KAXJ69wP1tGnf4ZGhUcel5euIg.woff2) format('woff2');}.material-icons{font-family:'Material Icons';font-weight:normal;font-style:normal;font-size:24px;line-height:1;letter-spacing:normal;text-transform:none;display:inline-block;white-space:nowrap;word-wrap:normal;direction:ltr;-webkit-font-feature-settings:'liga';-webkit-font-smoothing:antialiased;}.material-icons-outlined{font-family:'Material Icons Outlined';font-weight:normal;font-style:normal;font-size:24px;line-height:1;letter-spacing:normal;text-transform:none;display:inline-block;white-space:nowrap;word-wrap:normal;direction:ltr;-webkit-font-feature-settings:'liga';-webkit-font-smoothing:antialiased;}</style>\n<style>html{box-sizing:border-box;}*,:after,:before{box-sizing:inherit;}body,html{height:100%;}body{margin:0;padding:0;background-color:#fff;}.mat-typography{font:400 14px/20px Lato,sans serif;letter-spacing:normal;}</style><link rel=\"stylesheet\" href=\"styles.3ce8e31bee839ac54e2d.css\" media=\"print\" onload=\"this.media='all'\"><noscript><link rel=\"stylesheet\" href=\"styles.3ce8e31bee839ac54e2d.css\"></noscript></head>\n<body class=\"mat-typography\">\n  <agc-root></agc-root>\n<script src=\"runtime.a3850625a85d3cf32c03.js\" defer></script><script src=\"polyfills.aee990deaf1f8bb88a0e.js\" defer></script><script src=\"scripts.0bd2c7a50924e57de165.js\" defer></script><script src=\"main.02464b205bfc88a85335.js\" defer></script>\n\n</body></html>"
  }
}

Error (firefox):

{
  "headers": {
    "normalizedNames": {},
    "lazyUpdate": null
  },
  "status": 200,
  "statusText": "OK",
  "url": "https://node.cns.iu.edu/client/a2agc/staging/assets/generated/aggregate-table-data.json",
  "ok": false,
  "name": "HttpErrorResponse",
  "message": "Http failure during parsing for https://node.cns.iu.edu/client/a2agc/staging/assets/generated/aggregate-table-data.json",
  "error": {
    "error": {},
    "text": "<!DOCTYPE html><html lang=\"en\"><head><link rel=\"preconnect\" href=\"https://fonts.gstatic.com/\" crossorigin=\"\">\n  <meta charset=\"utf-8\">\n  <title>Indiana Opioid Dashboard</title>\n  <base href=\"/client/a2agc/\">\n  <meta name=\"viewport\" content=\"width=device-width, initial-scale=1\">\n  <link rel=\"icon\" type=\"image/x-icon\" href=\"favicon.ico\">\n  <style type=\"text/css\">@font-face{font-family:'Lato';font-style:normal;font-weight:300;font-display:swap;src:url(https://fonts.gstatic.com/s/lato/v23/S6u9w4BMUTPHh7USSwaPGQ3q5d0N7w.woff2) format('woff2');unicode-range:U+0100-024F, U+0259, U+1E00-1EFF, U+2020, U+20A0-20AB, U+20AD-20CF, U+2113, U+2C60-2C7F, U+A720-A7FF;}@font-face{font-family:'Lato';font-style:normal;font-weight:300;font-display:swap;src:url(https://fonts.gstatic.com/s/lato/v23/S6u9w4BMUTPHh7USSwiPGQ3q5d0.woff2) format('woff2');unicode-range:U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;}@font-face{font-family:'Lato';font-style:normal;font-weight:400;font-display:swap;src:url(https://fonts.gstatic.com/s/lato/v23/S6uyw4BMUTPHjxAwXiWtFCfQ7A.woff2) format('woff2');unicode-range:U+0100-024F, U+0259, U+1E00-1EFF, U+2020, U+20A0-20AB, U+20AD-20CF, U+2113, U+2C60-2C7F, U+A720-A7FF;}@font-face{font-family:'Lato';font-style:normal;font-weight:400;font-display:swap;src:url(https://fonts.gstatic.com/s/lato/v23/S6uyw4BMUTPHjx4wXiWtFCc.woff2) format('woff2');unicode-range:U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;}</style>\n  <style type=\"text/css\">@font-face{font-family:'Material Icons';font-style:normal;font-weight:400;src:url(https://fonts.gstatic.com/s/materialicons/v135/flUhRq6tzZclQEJ-Vdg-IuiaDsNcIhQ8tQ.woff2) format('woff2');}@font-face{font-family:'Material Icons Outlined';font-style:normal;font-weight:400;src:url(https://fonts.gstatic.com/s/materialiconsoutlined/v107/gok-H7zzDkdnRel8-DQ6KAXJ69wP1tGnf4ZGhUcel5euIg.woff2) format('woff2');}.material-icons{font-family:'Material Icons';font-weight:normal;font-style:normal;font-size:24px;line-height:1;letter-spacing:normal;text-transform:none;display:inline-block;white-space:nowrap;word-wrap:normal;direction:ltr;-webkit-font-feature-settings:'liga';-webkit-font-smoothing:antialiased;}.material-icons-outlined{font-family:'Material Icons Outlined';font-weight:normal;font-style:normal;font-size:24px;line-height:1;letter-spacing:normal;text-transform:none;display:inline-block;white-space:nowrap;word-wrap:normal;direction:ltr;-webkit-font-feature-settings:'liga';-webkit-font-smoothing:antialiased;}</style>\n<style>html{box-sizing:border-box;}*,:after,:before{box-sizing:inherit;}body,html{height:100%;}body{margin:0;padding:0;background-color:#fff;}.mat-typography{font:400 14px/20px Lato,sans serif;letter-spacing:normal;}</style><link rel=\"stylesheet\" href=\"styles.3ce8e31bee839ac54e2d.css\" media=\"print\" onload=\"this.media='all'\"><noscript><link rel=\"stylesheet\" href=\"styles.3ce8e31bee839ac54e2d.css\"></noscript></head>\n<body class=\"mat-typography\">\n  <agc-root></agc-root>\n<script src=\"runtime.a3850625a85d3cf32c03.js\" defer></script><script src=\"polyfills.aee990deaf1f8bb88a0e.js\" defer></script><script src=\"scripts.0bd2c7a50924e57de165.js\" defer></script><script src=\"main.02464b205bfc88a85335.js\" defer></script>\n\n</body></html>"
  }
}

Graphical glitch (chrome):

image

Graphical glitch (firefox):

image
@bherr2 bherr2 added bug Something isn't working and removed bug Something isn't working labels Apr 22, 2024
@edlu77 edlu77 mentioned this issue Apr 22, 2024
Merged
@bherr2 bherr2 closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edlu77 edlu77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bherr2 @edlu77