Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small fixes #148

Merged
merged 6 commits into from
Apr 22, 2024
Merged

Some small fixes #148

merged 6 commits into from
Apr 22, 2024

Conversation

edlu77
Copy link
Contributor

@edlu77 edlu77 commented Apr 22, 2024

@edlu77 edlu77 requested a review from bherr2 April 22, 2024 16:18
@edlu77 edlu77 self-assigned this Apr 22, 2024
* @returns true if not empty
*/
private isNotEmpty(input: RawData): boolean {
return Object.keys(input).length != 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!==

Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@bherr2 bherr2 merged commit dbb87cb into develop Apr 22, 2024
2 of 3 checks passed
@bherr2 bherr2 deleted the fixes-4-22 branch April 22, 2024 18:04
bherr2 pushed a commit that referenced this pull request Jun 24, 2024
* Some small fixes

* Make public if aggregate-table-json is empty

* Fix for empty object check

* Another fix (it works this time)

* Put back responseType

* Update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants