Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Tox reports #133

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

[DO NOT MERGE] Tox reports #133

wants to merge 5 commits into from

Conversation

edlu77
Copy link
Contributor

@edlu77 edlu77 commented Apr 12, 2023

No description provided.

@edlu77 edlu77 requested a review from bherr2 April 12, 2023 00:09
@edlu77 edlu77 self-assigned this Apr 12, 2023
@edlu77 edlu77 marked this pull request as ready for review April 17, 2023 20:58
bherr2
bherr2 reviewed Apr 19, 2023
View reviewed changes
data-processor/src/schema-typing/12-tox_reports.sql
SELECT
acct_num,
CASE fentanyl
WHEN 'Negative' THEN 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edlu77 are you sure all these boolean columns have a string "Negative" or "POSITIVE" and not any other casing? Seems odd.

@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bherr2 bherr2 changed the title Tox reports [DO NOT MERGE] Tox reports Feb 19, 2024
@bherr2 bherr2 marked this pull request as draft February 19, 2024 17:22
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bherr2 bherr2 bherr2 left review comments

Assignees

@edlu77 edlu77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edlu77 @bherr2