Transform options keys to symbols. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, any options with a String key (e.g. "host") instead of a Symbol key (e.g. :host) would get silently ignored. This is surprising in general but in particular, when using Rails and reading the `database.yml` config, they are all String keys so have no affect unless they are transformed before passing to `Trilogy.new`. This reduces the surprises and ensures the keys are all transformed to Symbols before accessing them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, any options with a String key (e.g. "host") instead of a Symbol key (e.g. :host) would get silently ignored.
This is surprising in general but in particular, when using Rails and reading the
database.ymlconfig, they are all String keys so have no affect unless they are transformed before passing toTrilogy.new.This reduces the surprises and ensures the keys are all transformed to Symbols before accessing them.