Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BP3#86): update for v4 #367

Merged
merged 6 commits into from
Dec 5, 2021
Merged

feat(BP3#86): update for v4 #367

merged 6 commits into from
Dec 5, 2021

Conversation

DocRoms
Copy link
Member

@DocRoms DocRoms commented Dec 4, 2021

Update de la BP#86 voir #144 (issue) et la discussion #38

@DocRoms DocRoms linked an issue Dec 4, 2021 that may be closed by this pull request
9 tasks
@DocRoms DocRoms requested review from florinesueur, tbroyer and ACTLEM and removed request for florinesueur and tbroyer December 4, 2021 11:09
@DocRoms
Copy link
Member Author

DocRoms commented Dec 4, 2021

Avec la version gratuite de gitHub, on ne peut pas spécifier plus d'un reviewer 😓.
Je ping ici toutes les personnes ayant participé à la discussion : @tbroyer @arnolem @florinesueur @ACTLEM @Christophe-Cl :)

Est-ce que ça vous convient ? J'ai essayer de placer tous les sujets de discussions dans la BP :)

@DocRoms DocRoms added the modification modification of a best practice label Dec 4, 2021
chapters/BP_086_fr.md Outdated Show resolved Hide resolved
chapters/BP_086_fr.md Outdated Show resolved Hide resolved
@DocRoms DocRoms self-assigned this Dec 4, 2021
chapters/BP_086_fr.md Outdated Show resolved Hide resolved
chapters/BP_086_fr.md Outdated Show resolved Hide resolved
@DocRoms
Copy link
Member Author

DocRoms commented Dec 5, 2021

Du coup, pour celle-ci tout est okay @ACTLEM , je peux merger ?

Romuald_Priol and others added 5 commits December 5, 2021 20:24
Co-authored-by: Florine Sueur <florine.sueur@outlook.fr>
Co-authored-by: Florine Sueur <florine.sueur@outlook.fr>
Co-authored-by: Thomas LEMAIRE <thomas.lemaire.actlem@gmail.com>
@ACTLEM ACTLEM merged commit 41c54a1 into main Dec 5, 2021
@ACTLEM ACTLEM deleted the feat/issue-144 branch December 5, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modification modification of a best practice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modification BP #86
3 participants