Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursion #8

Merged
merged 11 commits into from
Apr 22, 2024
Merged

Recursion #8

merged 11 commits into from
Apr 22, 2024

Conversation

co1emi11er2
Copy link
Owner

Release notes:

Added Features

  • Recursion through functions now works
  • @handcalcs macro suggested to be used for all cases now
  • not_funcs keyword to pass functions you do not want to unroll

Breaking changes

  • The @handcalcs macro will now automatically try to "unroll" the expressions within a function when the expression has the following pattern: variable = function_name(args...; kwargs...).
  • One issue that can arise are for the functions that you do not want to unroll. Consider the expression: y = sin(x) or y = x + 5. Both of these expressions match the format: variable = function_name(args...; kwargs...) and would be unrolled. This would result in an error since these functions don't have generic math expressions that can be latexified defining the function. You will need to use the not_funcs keyword to manually tell the @handcalcs macro to pass over these functions. Some of the common math functions that you will not want to unroll are automatically passed over.

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 94.91525% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 88.66%. Comparing base (71d9803) to head (d168f3e).

Files Patch % Lines
src/handcalc_marco.jl 92.10% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   87.40%   88.66%   +1.26%     
==========================================
  Files           5        5              
  Lines         254      300      +46     
==========================================
+ Hits          222      266      +44     
- Misses         32       34       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@co1emi11er2 co1emi11er2 merged commit 4e6e835 into master Apr 22, 2024
7 of 9 checks passed
@co1emi11er2 co1emi11er2 deleted the recursion branch April 22, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant