Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OcTree] Add method to save octree in obj file. #256

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

florent-lamiraux
Copy link
Contributor

No description provided.

Copy link
Contributor

@jmirabel jmirabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A unit test would be nice if you have time.

@florent-lamiraux florent-lamiraux merged commit 14a1cb0 into coal-library:devel Jan 31, 2022
Comment on lines +135 to +136
std::vector<std::array<FCL_REAL, 3> > vertices;
std::vector<std::array<std::size_t, 4> > faces;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the code C++11. I think there are still people requiring C++98 (not sure what for though).

filename + std::string("\""));
// write vertices
os << "# list of vertices" << std::endl;
for (auto v : vertices){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants