Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize Cmake use #420

Merged
merged 3 commits into from
May 12, 2023
Merged

Modernize Cmake use #420

merged 3 commits into from
May 12, 2023

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented May 11, 2023

No description provided.

jcarpent
jcarpent suggested changes May 11, 2023
View reviewed changes
Copy link
Contributor

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please split the PR into two parts? I’m not able to review between the precommit and the core change

@jcarpent jcarpent enabled auto-merge May 12, 2023 06:55
@jcarpent jcarpent merged commit f765272 into coal-library:devel May 12, 2023
@nim65s nim65s deleted the cmake branch November 17, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarpent jcarpent jcarpent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nim65s @jcarpent