Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization unit test when running without Qhull support #611

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Fix serialization unit test when running without Qhull support #611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e68b27
test: Don't run test on hpp::fcl::Convex without Qhull
jorisv Jul 19, 2024
767b84c
changelog: Add changelog entry
jorisv Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

### Fixed

- Fix Fix serialization unit test when running without Qhull support ([#611](https://github.com/humanoid-path-planner/hpp-fcl/pull/611))
- Compiler warnings ([#601](https://github.com/humanoid-path-planner/hpp-fcl/pull/601), [#605](https://github.com/humanoid-path-planner/hpp-fcl/pull/605))
- CMake: fix assimp finder
- Don't define GCC7 Boost serialization hack when `HPP_FCL_SKIP_EIGEN_BOOST_SERIALIZATION` is defined ([#530](https://github.com/humanoid-path-planner/hpp-fcl/pull/530))
Expand Down
2 changes: 2 additions & 0 deletions test/serialization.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,7 @@ BOOST_AUTO_TEST_CASE(test_shapes) {
test_serialization(plane, plane_copy);
}

#ifdef HPP_FCL_HAS_QHULL
{
const size_t num_points = 500;
std::shared_ptr<std::vector<Vec3f>> points =
Expand All @@ -526,6 +527,7 @@ BOOST_AUTO_TEST_CASE(test_shapes) {
Convex convex_copy;
test_serialization(*convex, convex_copy);
}
#endif
}

#ifdef HPP_FCL_HAS_OCTOMAP
Expand Down
Loading