Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSComplexityBear fails sometimes #729

Closed
sils opened this issue Aug 29, 2016 · 3 comments
Closed

JSComplexityBear fails sometimes #729

sils opened this issue Aug 29, 2016 · 3 comments
Assignees
@AbdealiLoKo
Labels
difficulty/low type/bug

Comments

@sils
Copy link
Member

sils commented Aug 29, 2016

Sometimes the output seems to be like
Fatal error [getReports]: /home/lasse/prog/kiwi/frontend/frontend/common/pages/Deals.js: Line 1: Unexpected token and then we try to jsonify it which fails the bear.

type/bug - we should do something about this.
@gitmate-bot
Copy link
Collaborator

Thanks for reporting this issue! A coalaian will look at it soon.

@sils
Copy link
Member Author

sils commented Aug 30, 2016 •
edited by AbdealiLoKo
Loading

We should log this as an error properly.

@sils
Copy link
Member Author

sils commented Aug 30, 2016

maybe we should in the general json case catch the decode error and log the unparsable JSON output with it so it's actually useful. We could pack that into a utility method so all JSON using bears can use it.

@AbdealiLoKo AbdealiLoKo self-assigned this Aug 31, 2016
AbdealiLoKo added a commit that referenced this issue Aug 31, 2016
@AbdealiLoKo
JSComplexityBear: Handle invalid syntax better
3b534b8 
Ths commits adds the feature to this bear to give a result when the tool
is unable to parse the code at all. This is given as a MAJOR error as
this a fault in the javascript code in itself.

Fixes #729
AbdealiLoKo added a commit that referenced this issue Aug 31, 2016
@AbdealiLoKo
JSComplexityBear: Handle invalid syntax better
cd322dd 
Ths commits adds the feature to this bear to give a result when the tool
is unable to parse the code at all. This is given as a MAJOR error as
this a fault in the javascript code in itself.

Fixes #729
AbdealiLoKo added a commit that referenced this issue Sep 1, 2016
@AbdealiLoKo
JSComplexityBear: Handle invalid syntax better
c3f011f 
Ths commits adds the feature to this bear to give a result when the tool
is unable to parse the code at all. This is given as a MAJOR error as
this a fault in the javascript code in itself.

Fixes #729
AbdealiLoKo added a commit that referenced this issue Sep 2, 2016
@AbdealiLoKo
JSComplexityBear: Handle invalid syntax better
c18f019 
Ths commits adds the feature to this bear to give a result when the tool
is unable to parse the code at all. This is given as a MAJOR error as
this a fault in the javascript code in itself.

Fixes #729
@rultor rultor closed this as completed in a281c6d Sep 2, 2016
sils pushed a commit that referenced this issue Sep 2, 2016
@AbdealiLoKo @sils
JSComplexityBear: Handle invalid syntax better
047b683 
Ths commits adds the feature to this bear to give a result when the tool
is unable to parse the code at all. This is given as a MAJOR error as
this a fault in the javascript code in itself.

Fixes #729
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
@AbdealiLoKo @sils
JSComplexityBear: Handle invalid syntax better
e37ca4c 
Ths commits adds the feature to this bear to give a result when the tool
is unable to parse the code at all. This is given as a MAJOR error as
this a fault in the javascript code in itself.

Fixes coala#729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbdealiLoKo AbdealiLoKo

Labels
difficulty/low type/bug
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AbdealiLoKo @sils @gitmate-bot