Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt: Add click 6.6 #1282

Merged
merged 1 commit into from
Jan 10, 2017
Merged

requirements.txt: Add click 6.6 #1282

merged 1 commit into from
Jan 10, 2017

Conversation

sils
Copy link
Member

@sils sils commented Jan 10, 2017

coala builds are currently failing. This is a hotfix. We should revert
this when mozilla/dennis#91 gets resolved or
alternatively remove DennisBear.

@gitmate-bot
Copy link
Collaborator

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

@adtac
Copy link
Member

adtac commented Jan 10, 2017

ack 291871b

@NiklasMM
Copy link
Contributor

ack 291871b

@NiklasMM
Copy link
Contributor

Looks good. Should we open a blocked issue to remove it again?

coala builds are currently failing. This is a hotfix. We should revert
this when mozilla/dennis#91 gets resolved or
alternatively remove DennisBear.

The dennis requirement is indirect while pip picks up this one:

    Collecting Click>=6.0 (from safety~=0.5.1->coala-bears[alldeps])

This fixes it to 6.6 so everything works temporarily.
@adtac
Copy link
Member

adtac commented Jan 10, 2017

ack f0e8955

@sils
Copy link
Member Author

sils commented Jan 10, 2017

@rultor merge

@rultor
Copy link

rultor commented Jan 10, 2017

@rultor merge

@sils OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit f0e8955 into master Jan 10, 2017
@rultor
Copy link

rultor commented Jan 10, 2017

@rultor merge

@sils Done! FYI, the full log is here (took me 1min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants