Sils/lints4 #354
Sils/lints4 #354
Conversation
| """ | ||
|
|
||
| LANGUAGES = ("Java",) |
There was a problem hiding this comment.
why is the comma necessary with one argument?
There was a problem hiding this comment.
("something") is the same as "something" but we want it to be a tuple, standard notation is ("something",)
There was a problem hiding this comment.
hm interesting issue though, maybe file an issue to support single items?
|
ack c1b502f |
| @staticmethod | ||
| def create_arguments(filename, file, config_file, | ||
| htmllint_ignore: typed_list(str)=()): | ||
| """ | ||
| :param htmllint_include: List of checkers to ignore. |
There was a problem hiding this comment.
:param htmllint_ignore: right?
|
unack c1b502f |
| use_stdin=True) | ||
| class RuboCopBear: | ||
| """ | ||
| Checks the code with ``rubocop``. This will run ``rubocop`` over each of |
There was a problem hiding this comment.
Ignore if we are not strict with having imperatives here.
There was a problem hiding this comment.
this commit doesn't change the docs, it's a refactoring of the code
There was a problem hiding this comment.
Oh cool 👍
ᐧ
On Mon, Apr 25, 2016 at 11:42 PM, Lasse Schuirmann <notifications@github.com
wrote:
In bears/ruby/RuboCopBear.py
#354 (comment)
:-class RuboCopBear(LocalBear, Lint):
- executable = 'rubocop'
Need both stdin and filename. Explained in the comment:
[Fix #1682] Add STDIN support rubocop/rubocop#2146 (comment)
- arguments = '{filename} --stdin --format=json'
- severity_map = {
"error": RESULT_SEVERITY.MAJOR,"warning": RESULT_SEVERITY.NORMAL,"convention": RESULT_SEVERITY.INFO- }
- use_stdin = True
+@LINTER(executable='rubocop',use_stdin=True)- """
- Checks the code with
rubocop. This will runrubocopover each ofthis commit doesn't change the docs, it's a refactoring of the code
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/coala-analyzer/coala-bears/pull/354/files/7466e381198059dfd0b91a580972dd751faa0f34..cbb76220bbaf3377f020001ea937fffb95152c25#r60960389
|
ack 9049270 |
|
ack 7684ca8 |
Needed for checkstylebear to get refactored.
|
ack 930bc8d |
|
unack |
|
ack c1e766a |
| @@ -9,9 +9,15 @@ | |||
| @linter(executable='hlint') | |||
| class HaskellLintBear: | |||
| """ | |||
| Checks the given file with ``hlint``. | |||
| Check Haskell code for possible problems. Fixes include ideas such as using | |||
| alternative functions, simplifying code and removing redundancies. | |||
There was a problem hiding this comment.
Fixes include: ideas such as..
|
coverage is 100% |
Current coverage is 99.93%@@ master #354 diff @@
==========================================
Files 73 73
Lines 1394 1359 -35
Methods 0 0
Messages 0 0
Branches 211 211
==========================================
- Hits 1393 1358 -35
Misses 0 0
Partials 1 1
|
|
@rultor merge |
No description provided.