Benchmark sanitization and minor additions #1207
Conversation
| Due to dependency issues, currently all benchmarks are packaged and run separately. | ||
|
|
||
| They are intended to be incorporated into a cohesive benchmark suite using a coalton benchmarking framework at a later date. |
There was a problem hiding this comment.
if this doesn't get deleted, then capitalize Coalton
| Due to dependency issues, currently all benchmarks are packaged and run separately. |
There was a problem hiding this comment.
This sounds like airing dirty laundry. I'd reword this to just be direct. "This system contains a variety of individual benchmarks. This system does not presently have a single, unified benchmark suite."
There was a problem hiding this comment.
Maybe state that by convention, functions ending in -main are intended to be a single reasonable and repeatable benchmarking function requiring no arguments.
Other conventions can be stated as well. Maybe
benchmark-*
should be any kind of function intended to be a benchmark, and
main-benchmark
should always be the name of the main benchmark of a package?
| -> (Complex :a) | ||
| -> Integer)) | ||
| (define (escapes? limit fc div? z0) | ||
| "Returns the number of iterations of the function F " |
| @@ -0,0 +1,179 @@ | |||
| (defpackage #:coalton/benchmarks/benchmarks-game/mandelbrot | |||
There was a problem hiding this comment.
we should write a comment on what this code is benchmarking. i don't mean documenting what mandelbrot is, but rather "this code benchmarks highly polymorphic complex numerics, and high order functions. the code is written in a relatively idiomatic functional style." or so
|
|
||
| (define (too-simple-main n) | ||
| (time (fn () | ||
| (let sum = (cell:new 0.0d0)) |
There was a problem hiding this comment.
lift the fn out into its own function
|
|
||
| (define (too-simple-main2 n) | ||
| (time (fn () | ||
| (let ((declare run (Double-Float -> Double-Float -> Double-Float -> Double-Float)) |
| (let x = (into x)) | ||
| (* x (* pi ee)))))) | ||
|
|
||
| ;;(cl:in-package #:coalton-benchmarks) |
|
|
||
| ;;(cl:in-package #:coalton-benchmarks) | ||
|
|
||
| #+ig |
There was a problem hiding this comment.
figure out what to do with these
|
|
||
| ;;(cl:in-package #:coalton-benchmarks) | ||
|
|
||
| #+ig (define-benchmark recursive-fib () |
There was a problem hiding this comment.
figure out what to do here.
|
Whoops, I thought I marked it as a draft |
Izaakwltn
force-pushed
the
benchmark-cleanup
branch
from
f6321b4
to
f90c0af
Compare
Addressing issue #1204, this sanitizes the directory while we figure out how to replace
trivial-benchmarks.trivial-benchmarksas a dependencyThis also adds two benchmarks from the Benchmarks Game, with hopeful additions coming soon.
I think next steps (for future PR(s)) should include a simple Coalton benchmarking framework, ideally without external dependencies, and incorporation of benchmarks into CI.