Add RST packet processing fixes #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @GiedriusM - looks nice. I will test this next week to see if there any side effects. |
|
Thanks, I'll add you as a reviewer then. |
|
Merged with the (hopefully) working fix. Tests seem to pass without any disturbances. |
|
finally - could test with my app, LGTM! |
|
Thanks, @neophob! I'll merge it once you validate the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues when processing RST packets, including original issue #154:
Could anyone review the changes? @mcollina @neophob?
Also, I was unsure how should I handle a RST as a response - at first I did a separate req.on('reset') event, but then just slapped RST into response as it does not alter the API. Which do you guys think is better?