-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: exclude TS source files from publishing #342
Conversation
Pull Request Test Coverage Report for Build 2216186100
💛 - Coveralls |
What about examples dir? Or some of the *.md? What should be in the package? |
Running
|
ts is "github only" in my eyes, but I would include the examples |
b25faea
to
7e174b6
Compare
Alright :) I added the examples now but excluded the tests which should also reduce the bundle size. |
Dry run now looks like this:
|
I did not checked that "dist" is containing anything needed. |
At the moment, we also publish the Typescript source files when uploading to npm which increases the bundle size. This PR would exclude them from publishing. However, also including the source files potentially makes debugging easier for users of the library.
Do you think we should remove the source files? Then we could simply merge this PR. Or should we keep them?